[extension/healthcheckv2extension] Refactor internal/status to pkg/status

[blakerouse]

Description

Refactors the extension/healthcheckv2extension/internal/status into pkg/status.

This exposes the aggregator to be used by other extensions to gather component status information using the extension.StatusWatcher.

Link to tracking issue

Closes #34692

Testing

Being it was a refactor and all the same tests provided coverage, no additional testing was added.

Documentation

Added a README.md to the pkg/status to provide information on where this package can be used.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: blakerouse / name: Blake Rouse (266d6a6, 1dd28a4, 3bfaf24, 6b6775d, b102db7, cf552b9, 6f41451, 2337a41, a0b822c, 66bdb10, ce4d5d6, 933c454, 106f915, 8b061f2, c10318e, 59fd714)
• ✅ login: mwear / name: Matthew Wear (d880732, 0b029f1)

[mwear]

Thanks for taking on this refactor. I made a PR to this PR with a few additional updates that will be needed. In addition to those, this should have a changelog entry. Run make chlog-new to generate one and fill in the details.

[blakerouse]

@mwear Thanks for the cleanup PR. I have merged your PR and updated the README.md to the updated interface name.

[blakerouse]

@mwear Forgot about the changelog. I have added that as well.

[mwear]

LGTM, thanks @blakerouse!

cc: @bacherfl, @evan-bradley re: #35488.

[evan-bradley]

Thank you @blakerouse!

Overall this looks good to me, I just have comments on a few supplementary details.

[blakerouse]

@evan-bradley I have update the requested items.

But running mage -C pkg/status generate resulted in:

make: *** No rule to make target `generate'.  Stop.

[mwear]

But running make -C pkg/status generate resulted in:

make: *** No rule to make target `generate'.  Stop.

I'm not sure why that doesn't work for a subdirectory, but you can run make generate from the root and will run for each contrib component. It's slow, but it will get the job done.

[blakerouse]

@mwear I did do that. I didn't see it generate or do anything. Maybe there is nothing to generate?

[mwear]

@mwear I did do that. I didn't see it generate or do anything. Maybe there is nothing to generate?

It looks like there are two more changes needed:

Add a doc.go file with the following contents:

// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

//go:generate mdatagen metadata.yaml

package status // import "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/status"

Update metadata.yml to include a type, you can just copy this:

type: status

status:
  class: pkg
  stability:
    development: [extension]
  codeowners:
    active: [jpkrohling, mwear]

I found that if you cd into the pkg/status directory you can run mdatagen metadata.yml to generate for a specific component. make generate from the root should also work after these changes.

[blakerouse]

@mwear @evan-bradley Thanks for the help on getting this ready. I think its ready now as the generation logic worked this time and filled in the correct information in the README.

[mwear]

The currently failing CI check says to run make generate-gh-issue-templates and commit the changes.

[blakerouse]

@mwear Okay. maybe now its ready. 😄

[evan-bradley]

Thank you @blakerouse! Your patience while working through the process of setting up a new module is appreciated.

[blakerouse]

No problem! Glad to help.