Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/dbstorage] support for Postgres #35757

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 12, 2024

Description

Adds support for Postgres, using a test running a Postgresql docker image.

Link to tracking issue

Fixes #35692

Testing

Run a postgresql image and test with it.

@atoulme atoulme requested review from dmitryax and a team as code owners October 12, 2024 08:06
@github-actions github-actions bot requested a review from djaglowski October 12, 2024 08:07
@atoulme atoulme force-pushed the postgres_support branch 2 times, most recently from 49df177 to a6d3895 Compare October 14, 2024 15:37
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Oct 15, 2024
@andrzej-stencel
Copy link
Member

@atoulme please resolve conflicts and we'll merge.

@songy23 songy23 removed the ready to merge Code review completed; ready to merge by maintainers label Oct 30, 2024
@atoulme
Copy link
Contributor Author

atoulme commented Nov 2, 2024

@andrzej-stencel rebased thanks.

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Nov 2, 2024
@andrzej-stencel andrzej-stencel merged commit 6c471a4 into open-telemetry:main Nov 5, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 5, 2024
michael-burt pushed a commit to michael-burt/opentelemetry-collector-contrib that referenced this pull request Nov 7, 2024
#### Description
Adds support for Postgres, using a test running a Postgresql docker
image.

#### Link to tracking issue
Fixes open-telemetry#35692

#### Testing
Run a postgresql image and test with it.
@atoulme atoulme deleted the postgres_support branch November 10, 2024 05:39
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
#### Description
Adds support for Postgres, using a test running a Postgresql docker
image.

#### Link to tracking issue
Fixes open-telemetry#35692

#### Testing
Run a postgresql image and test with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension/storage ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[extension/storage/dbstorage] pgx support not wokring because db queries are sqlite specific
7 participants