Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Set body.* for log body in OTel mode #35771

Merged
merged 6 commits into from
Oct 15, 2024

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented Oct 14, 2024

Description

Update OTel mode to implementation to serialize log body into body.* fields

Link to tracking issue

Testing

Documentation

Copy link
Contributor

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But maybe add some tests.

.chloggen/elasticsearchexporter_otel-mode-log-body.yaml Outdated Show resolved Hide resolved
@carsonip
Copy link
Contributor Author

Fixed typo and added tests

Copy link
Member

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit.

exporter/elasticsearchexporter/model.go Outdated Show resolved Hide resolved
@andrzej-stencel andrzej-stencel merged commit fb114a6 into open-telemetry:main Oct 15, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants