[Receiver/Kafka] feat: Add topic to internal consume-claim metric attributes (35336)

[StephanSalas]

Description

Added the "topic" attribute to the following internal telemetry metrics:

1. KafkaReceiverMessages
2. KafkaReceiverCurrentOffset
3. KafkaReceiverOffsetLag
4. KafkaReceiverUnmarshalFailedSpans
5. KafkaReceiverUnmarshalFailedMetricPoints
6. KafkaReceiverUnmarshalFailedLogRecords

Link to tracking issue

Fixes #35336

Testing Performed

Tested locally and observed new attribute

Documentation Added

No documentation changes needed because internal metric attributes are not typically documented (except for the basic metric details in the existing generated_telemetry.go). Thus they were not added, but let me know if they need to be :)

[MovieStoreGuy]

I suggest adding the attributes via the metadata.yml since this will automatically generate the code and the docs for users.

See mdatagen command for reference.

[StephanSalas]

I suggest adding the attributes via the metadata.yml since this will automatically generate the code and the docs for users.

See mdatagen command for reference.

@MovieStoreGuy, looks like it won't generate docs per my attempts just now and also the bug listed here: open-telemetry/opentelemetry-collector#10926 (comment). The mdatagen attribute schema validates my changes, however it just doesn't generate anything in the docs or otherwise even though both go generate and mdatagen metadata.yaml commands succeed.

Given that, would you prefer I still commit my updated metadata.yaml for this PR, or wait until the mdatagen fix is released (to also check in the gen'd docs)? The latter option may be easier to track as a separate PR for receiver/Kafka and other affected components.

[StephanSalas]

Hey Reviewers,

Given the issue with the doc generation, can this be merged as-is? I do see a related issue with the metrics that may depend a bit on this as well that I am also working on: #36093.

[StephanSalas]

Hey Reviewers,

Given the issue with the doc generation, can this be merged as-is? I do see a related issue with the metrics that may depend a bit on this as well that I am also working on: #36093.

@MovieStoreGuy, just wanted to add a bump to this Q. Let me know if that approach is satisfactory while open-telemetry/opentelemetry-collector#10926 (comment) is still an ongoing issue.

[MovieStoreGuy]

I suggest adding the attributes via the metadata.yml since this will automatically generate the code and the docs for users.
See mdatagen command for reference.

@MovieStoreGuy, looks like it won't generate docs per my attempts just now and also the bug listed here: open-telemetry/opentelemetry-collector#10926 (comment). The mdatagen attribute schema validates my changes, however it just doesn't generate anything in the docs or otherwise even though both go generate and mdatagen metadata.yaml commands succeed.

Given that, would you prefer I still commit my updated metadata.yaml for this PR, or wait until the mdatagen fix is released (to also check in the gen'd docs)? The latter option may be easier to track as a separate PR for receiver/Kafka and other affected components.

Annoying but it makes sense.

[StephanSalas]

I suggest adding the attributes via the metadata.yml since this will automatically generate the code and the docs for users.
See mdatagen command for reference.

@MovieStoreGuy, looks like it won't generate docs per my attempts just now and also the bug listed here: open-telemetry/opentelemetry-collector#10926 (comment). The mdatagen attribute schema validates my changes, however it just doesn't generate anything in the docs or otherwise even though both go generate and mdatagen metadata.yaml commands succeed.
Given that, would you prefer I still commit my updated metadata.yaml for this PR, or wait until the mdatagen fix is released (to also check in the gen'd docs)? The latter option may be easier to track as a separate PR for receiver/Kafka and other affected components.

Annoying but it makes sense.

I have just updated the ChangeLog to hopefully pass the previously failed pipeline.

[StephanSalas]

QQ as a first time PR contributor. Do the pipelines usually take this long or is it just a quick "hit the reboot button" type of thing?

Stephan

[StephanSalas]

@MovieStoreGuy, anything we still need to do to get this merged?

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[andrzej-stencel]

Looks like tests need to be updated?