[k8scluster/receiver] Add more e2e test coverage #36114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
crobert-1,
dmitryax,
povilasv and
TylerHelmuth
jvoravong
force-pushed
the
OTL-2976-e2e-tests
branch
from
d5e2292
to
d5be42e
Compare
atoulme
reviewed
Oct 31, 2024
atoulme
reviewed
Oct 31, 2024
jvoravong
force-pushed
the
OTL-2976-e2e-tests
branch
from
d5be42e
to
402b28b
Compare
jvoravong
force-pushed
the
OTL-2976-e2e-tests
branch
from
402b28b
to
0df9e8c
Compare
Co-authored-by: Antoine Toulme <antoine@toulme.name>
|
Can someone add a "Skip Changelog" label to this PR? |
TylerHelmuth
added
the
Skip Changelog
povilasv
approved these changes
Nov 4, 2024
TylerHelmuth
approved these changes
Nov 4, 2024
TylerHelmuth
added
the
ready to merge
ChrsMark
approved these changes
Nov 5, 2024
This was referenced Nov 6, 2024
michael-burt
pushed a commit
to michael-burt/opentelemetry-collector-contrib
that referenced
this pull request
Nov 7, 2024
#### Description - Add more e2e test coverage for cronjob, hpa, job, and statefulset objects - Updated the golden file (expected.yaml) used for test validation - Added some test helpers to help create and delete multiple Kubernetes test objects - No .chloggen entry is needed for this PR because all the changes are for testing enhancements <!--Describe what testing was performed and which tests were added.--> #### Testing - Tested locally and in Github CI/CD --------- Co-authored-by: Antoine Toulme <antoine@toulme.name> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
TylerHelmuth
pushed a commit
that referenced
this pull request
Nov 7, 2024
…to 1 (#36235) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fixes what was described at #35727 (comment). After #36114 the `k8scluster` receiver's e2e tests started showing some flakiness ([example](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11701936581/job/32589392145)). With this change we ensure that only 1 active job/pod of the cronjob will be present for the whole lifetime of the test to avoid hitting timing/scheduling related flakiness. @bacherfl could you also take a look here? <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
pull bot
pushed a commit
to abaguas/opentelemetry-collector-contrib
that referenced
this pull request
Nov 7, 2024
…to 1 (open-telemetry#36235) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fixes what was described at open-telemetry#35727 (comment). After open-telemetry#36114 the `k8scluster` receiver's e2e tests started showing some flakiness ([example](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11701936581/job/32589392145)). With this change we ensure that only 1 active job/pod of the cronjob will be present for the whole lifetime of the test to avoid hitting timing/scheduling related flakiness. @bacherfl could you also take a look here? <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing