[receiver/hostmetrics]: change uptime scraper to system scraper #36123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes some changes that I had hoped to suggest on the PR that introduced the uptime scraper, however I was unable to make my comment in time before the PR was merged. * The `uptime` scraper is changed to be named `system` * The scraper is registered using the scraper name when adding to the scrapercontroller
|
I am ideally hoping that this change makes it in before a new OTel Collector is tagged so that no users start using |
|
I would like to skip changelog, because in this case what I did was modified the existing changelog to reflect this new change. |
|
@kevinnoel-be I am unable to officially add you as a reviewer on this PR, but if you have a second to take a look I would appreciate it! |
receiver/hostmetricsreceiver/internal/scraper/systemscraper/factory_test.go
Outdated
Show resolved
Hide resolved
|
@braydonk looks good to me except for the use of one (test) module where I think it should be testify instead? |
ChrsMark
approved these changes
Nov 5, 2024
michael-burt
pushed a commit
to michael-burt/opentelemetry-collector-contrib
that referenced
this pull request
Nov 7, 2024
…-telemetry#36123) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR makes some changes that I had hoped to suggest on open-telemetry#35954, however I was unable to make my comment in time before the PR was merged. The changes this PR makes are: * The `uptime` scraper is changed to be named `system` * The scraper is registered using the scraper name when adding to the scrapercontroller <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Amends the fix to open-telemetry#31627 (following a comment I made on open-telemetry#35932) <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation The documentation that was added for the `uptime` scraper was renamed accordingly, and the description adjusted. <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some changes that I had hoped to suggest on #35954, however I was unable to make my comment in time before the PR was merged.
The changes this PR makes are:
uptimescraper is changed to be namedsystemLink to tracking issue
Amends the fix to #31627 (following a comment I made on #35932)
Testing
Documentation
The documentation that was added for the
uptimescraper was renamed accordingly, and the description adjusted.