(internal/otelarrow) Add new LIFO boundedqueue #36140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The residual portion of #36033 is now drafted in #36141. It is a fairly small change. @andrzej-stencel let me know if this approach sounds good to you. For that PR to pass its tests, the contents of this PR would be merged first. Then, the old |
moh-osman3
reviewed
Nov 4, 2024
…tor-contrib into jmacd/newboundedqueue
lquerel
reviewed
Nov 6, 2024
…tor-contrib into jmacd/newboundedqueue
lquerel
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Thanks for creating the GH issue open-telemetry/otel-arrow#270 for tracking.
LGTM.
|
No changelog is needed, the next step #36141 where we use this code will have a user-relevant changelog. |
…tor-contrib into jmacd/newboundedqueue
…y-collector-contrib into jmacd/newboundedqueue
…tor-contrib into jmacd/newboundedqueue
mwear
approved these changes
Nov 11, 2024
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new LIFO-based bounded queue implementation for use by OTel-Arrow receiver admission control logic. This code is similar to but different than the existing bounded queue implementation. This code fixes a race condition discovered in the original package, which occurs when the admission is granted concurrently with context cancellation. This code is extracted from #36033, which demonstrates a final-state solution to #36074 and has been broken into parts to make reviews easier.
There are two substantial changes in this bounded queue implementation, although they appear similar. Because the differences between the old and new are relatively meaningless, and because the overall change is large, this PR proposes to add a new library of code that will not be used until a future PR.
The two substantial changes are:
In addition, this fixes a race in the FIFO queue: when a task is canceled concurrently with being admitted, the resource will leak.
Because the changes were so significant, I chose to start from scratch with testing. The replacement tests have 100% coverage and are fairly readable.
After this merges, the residual portion of #36033 will be a small change. In addition, by taking this approach we can close #36100 because #36033 will have been reduced to a small change that only replaces
waiter_limitwithwaiting_limit_mib.Link to tracking issue
Part of #36074.
Testing
New tests have 100% coverage.
Documentation
README added.