[exporter/datadog] Stop prefixing 3 HTTP metrics #36265
Merged
+78
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
commented
Nov 7, 2024
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
liustanley and
mackjmr
mx-psi
approved these changes
Nov 8, 2024
|
@songy23 Is this good to merge? Do we want to align it in some way with Agent changes? |
|
@mx-psi this is good to merge, the fix is primarily for collector. Agent can follow its own release schedule |
pull bot
pushed a commit
to abaguas/opentelemetry-collector-contrib
that referenced
this pull request
Nov 8, 2024
#### Description Stop prefixing `http_server_duration`, `http_server_request_size` and `http_server_response_size` with `otelcol`. Those metrics used to have the `otelcol` prefix if they are from collector internal metrics before v0.106, then the prefix was removed. We put back the prefix in v0.108 but the same metric can be from SDKs as well. Stop prefixing them be consistent with https://opentelemetry.io/docs/collector/internal-telemetry/#lists-of-internal-metrics
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
#### Description Stop prefixing `http_server_duration`, `http_server_request_size` and `http_server_response_size` with `otelcol`. Those metrics used to have the `otelcol` prefix if they are from collector internal metrics before v0.106, then the prefix was removed. We put back the prefix in v0.108 but the same metric can be from SDKs as well. Stop prefixing them be consistent with https://opentelemetry.io/docs/collector/internal-telemetry/#lists-of-internal-metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stop prefixing
http_server_duration,http_server_request_sizeandhttp_server_response_sizewithotelcol.Those metrics used to have the
otelcolprefix if they are from collector internal metrics before v0.106, then the prefix was removed. We put back the prefix in v0.108 but the same metric can be from SDKs as well. Stop prefixing them be consistent with https://opentelemetry.io/docs/collector/internal-telemetry/#lists-of-internal-metrics