Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/opamp] Add Opampextension content type #36327

Merged

Conversation

minuk-dev
Copy link
Contributor

@minuk-dev minuk-dev commented Nov 12, 2024

Description

  • [extension/opampextension] Add "text/yaml" toEffectiveConfig.ConfigMap.ConfigMap[*].ContentType:

ref. https://opentelemetry.io/docs/specs/opamp/#configuration

content_type is an optional field. It is a MIME Content-Type that describes what’s contained in the body field, for example “text/yaml”. The content_type reported in the Effective Configuration in the Agent’s status report may be used for example by the Server to visualize the reported configuration nicely in a UI.

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minuk-dev!

@evan-bradley evan-bradley merged commit 354f41a into open-telemetry:main Nov 13, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 13, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
- from
open-telemetry#36157

#### Description
- [extension/opampextension] Add "text/yaml"
toEffectiveConfig.ConfigMap.ConfigMap[*].ContentType:

ref. https://opentelemetry.io/docs/specs/opamp/#configuration
> content_type is an optional field. It is a MIME Content-Type that
describes what’s contained in the body field, for example “text/yaml”.
The content_type reported in the Effective Configuration in the Agent’s
status report may be used for example by the Server to visualize the
reported configuration nicely in a UI.

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants