[connector/spanmetrics] Fix spanmetrics for child spans #36718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivanthzen
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
not stale |
|
@shivanthzen are you able to look at the failing tests? For example: |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
not stale |
Apparently, for delta temporality, all the metrics collected are reset to empty state after consuming one round of data. Hence storing the lastseentimestamp within the metric doesn't work. This PR moves lastseentimestamp out of metric into a map (as it was stored previously) of
shivanthzen
force-pushed
the
fix_spanmetrics
branch
from
b13e4d0 to
fc56cd1
Compare
|
@portertech Sorry about the delay. Please take another look. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
@portertech please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, metric start timestamps are associated with the parent span (resource level). This means that all child spans, even those that occur asynchronously or infrequently, inherit the same start timestamp. This can lead to inaccurate data.
This merge request proposes moving the start timestamp (and last seen timestamp) from the parent span level to the individual child span (metric) level. This will ensure that each metric has its own accurate start and last seen timestamps, regardless of its relationship to other spans.
Link to tracking issue
Fixes #35994
Testing
Documentation