[exporter/elasticsearch] support both go-elasticsearch v7 & v8 #37187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
elasticsearchexporter-goelasticsearchv8
branch
4 times, most recently
from
d4af93a to
663e451
Compare
carsonip
reviewed
Jan 17, 2025
Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
axw
force-pushed
the
elasticsearchexporter-goelasticsearchv8
branch
from
52f11e8 to
a40e956
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closing in favour of #37333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use go-elasticsearch/v8 (which is being actively developed) by default, and add a
versionconfiguration setting that can be set to7to use go-elasticsearch/v7.(Note that I think it's worth having a discussion about whether this is worthwhile, since v8 will support 7.17.x, and older version of Elasticsearch are EOL. See #32454 (comment))
Link to tracking issue
Fixes #32454
Testing
TODO
Documentation
Updated README with a new section on Elasticsearch version compatibility.