[processor/logdedup] Add include_fields option #37219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauri870
force-pushed
the
logdedup-key
branch
from
ebd4402 to
1731356
Compare
mauri870
force-pushed
the
logdedup-key
branch
from
6a2a9d9 to
fb7810c
Compare
mauri870
changed the title
mauri870
force-pushed
the
logdedup-key
branch
from
fb7810c to
e243145
Compare
MikeGoldsmith
suggested changes
Jan 17, 2025
There was a problem hiding this comment.
Look good, thanks for your work on this @mauri870. I've left some minor feedback but think it's close 👍🏻
Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
MikeGoldsmith
approved these changes
Jan 21, 2025
djaglowski
approved these changes
Jan 21, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
#### Link to tracking issue Fixes open-telemetry#36965 <!--Describe what testing was performed and which tests were added.--> #### Testing Added tests that validate the new `include_fields` option as well as integration tests with ConsumeLogs. <!--Describe the documentation added.--> #### Documentation Added documentation for the new `include_fields` option as well as a README example. --------- Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to tracking issue
Fixes #36965
Testing
Added tests that validate the new
include_fieldsoption as well as integration tests with ConsumeLogs.Documentation
Added documentation for the new
include_fieldsoption as well as a README example.