-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/resourcedetection] Add fail_on_missing_metadata to EC2 detector #37453
[processor/resourcedetection] Add fail_on_missing_metadata to EC2 detector #37453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I wonder if a similar generic option should be available to all resource processors: the fact that one can start and not have the proper attributes can be considered an error in many scenarios.
there is no uniform behavior for all detectors, that can be a followup issue for the processor as a whole. |
63fb69d
to
2bbb8ff
Compare
Thanks! Rebased. |
…ector (open-telemetry#37453) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Add `fail_on_missing_metadata` option on EC2 detector If the EC2 metadata endpoint is unavailable, the EC2 detector by default ignores the error. By setting `fail_on_missing_metadata` to true on the detector, the user will now trigger an error explicitly, which will stop the collector from starting. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Relates to open-telemetry#35936
Description
Add
fail_on_missing_metadata
option on EC2 detectorIf the EC2 metadata endpoint is unavailable, the EC2 detector by default ignores the error.
By setting
fail_on_missing_metadata
to true on the detector, the user will now trigger an error explicitly,which will stop the collector from starting.
Link to tracking issue
Relates to #35936