[processor/tailsampling] Minor rework to improve performance #37560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Porter <portertech@gmail.com>
…lls, less branching Signed-off-by: Sean Porter <portertech@gmail.com>
Signed-off-by: Sean Porter <portertech@gmail.com>
Signed-off-by: Sean Porter <portertech@gmail.com>
…revert policies Signed-off-by: Sean Porter <portertech@gmail.com>
Signed-off-by: Sean Porter <portertech@gmail.com>
Signed-off-by: Sean Porter <portertech@gmail.com>
jpkrohling
approved these changes
Jan 29, 2025
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Feb 8, 2025
…lemetry#37560) This pull-request reworks the consume traces, sampling decision, and policy loading paths to improve performance and readability. Pressing the current architecture for the best results, by reducing allocations and calls when sensible. The `makeDecision()` changes alone resulted in a noticeable improvement, using the existing benchmark: `Sampling-8 16.37µ ± 2% 10.96µ ± 3% -33.02% (p=0.000 n=10)` --------- Signed-off-by: Sean Porter <portertech@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request reworks the consume traces, sampling decision, and policy loading paths to improve performance and readability. Pressing the current architecture for the best results, by reducing allocations and calls when sensible.
The
makeDecision()changes alone resulted in a noticeable improvement, using the existing benchmark:Sampling-8 16.37µ ± 2% 10.96µ ± 3% -33.02% (p=0.000 n=10)