Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Adapt e2e tests to also test statements with path context names #37741

Conversation

edmocosta
Copy link
Contributor

Description

This PR adaps the e2e tests to run both the old syntax as it's, and the new one by leveraging the parser collection context prepend feature, giving us some extra coverage without having to duplicate every single test.

Link to tracking issue

#29017

@TylerHelmuth TylerHelmuth added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 6, 2025
@edmocosta edmocosta marked this pull request as ready for review February 6, 2025 15:31
@edmocosta edmocosta requested a review from a team as a code owner February 6, 2025 15:31
@TylerHelmuth TylerHelmuth merged commit e296b0f into open-telemetry:main Feb 6, 2025
177 of 178 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 6, 2025
chengchuanpeng pushed a commit to chengchuanpeng/opentelemetry-collector-contrib that referenced this pull request Feb 8, 2025
…names (open-telemetry#37741)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This PR adaps the `e2e` tests to run both the old syntax as it's, and
the new one by leveraging the parser collection context prepend feature,
giving us some extra coverage without having to duplicate every single
test.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

open-telemetry#29017

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/ottl Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants