Add ECS relevant info for container insight receiver #3864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 20, 2021
…us advanced features (#3864) With this change, we reject advanced Prometheus features that the collector won't support. This way users will be cognizant of what isn't supported. This way, anyone who adds this configuration to their Prometheus receiver section ```yaml receivers: prometheus: buffer_period: 234 buffer_count: 45 use_start_time_metric: true start_time_metric_regex: '^(.+_)*process_start_time_seconds$' config: scrape_configs: - job_name: 'demo' scrape_interval: 5s remote_write: - url: "https://example.org/write" remote_read: - url: "https://example.org/read" rule_files: ["a", "b"] alerting: alert_relabel_configs: - separator: "," target_label: "fix" - separator: "|" target_label: "gotham" alertmanagers: - scheme: "http" path_prefix: "/prefix1" timeout: 1s ``` will be shown what we don't support these features with this error message: ```shell receiver "prometheus" has invalid configuration: unsupported features: alert_config.alertmanagers alert_config.relabel_configs remote_read remote_write rule_files ``` Fixes #3864 Fixes open-telemetry/prometheus-interoperability-spec#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This commit add the ecs info that are used by container insight receiver for ecs instance level metrics. This includes:
Get task info, clusterName and containerInstanceId from Amazon ECS container agent introspection.
Get reserved_cpu from Cgroup based on task id and clusterName.
Get reserved_mem from Cgroup based on task id, clustername and container info from task info.
Link to tracking Issue:
#2307
Testing:
Unit test
Documentation: