Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme for AWS Container Insights Receiver #3880

Merged
merged 3 commits into from
Jun 30, 2021
Merged

Update readme for AWS Container Insights Receiver #3880

merged 3 commits into from
Jun 30, 2021

Conversation

pxaws
Copy link
Contributor

@pxaws pxaws commented Jun 25, 2021

Description:

  • update the architecture diagram
  • update the metrics and attributes
  • add a sample configuration

Link to tracking Issue:
#2307

@pxaws pxaws requested review from a team and djaglowski June 25, 2021 22:07
@pxaws
Copy link
Contributor Author

pxaws commented Jun 25, 2021

@Aneurysm9 @anuraaga Could you take a look? Thanks!

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like more a design doc than a readme. Can we split it out to a separate doc and make this focused on how to configure the component?

@pxaws
Copy link
Contributor Author

pxaws commented Jun 28, 2021

This seems like more a design doc than a readme. Can we split it out to a separate doc and make this focused on how to configure the component?

It makes sense. I split the doc into readme and design doc.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the README is much cleaner. Just one nit

receiver/awscontainerinsightreceiver/README.md Outdated Show resolved Hide resolved
@alolita alolita changed the title Update readme for aws container insights receiver Update readme for AWS Container Insights Receiver Jun 29, 2021
Copy link
Member

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@alolita alolita added the ready to merge Code review completed; ready to merge by maintainers label Jun 29, 2021
@bogdandrutu bogdandrutu merged commit f01d911 into open-telemetry:main Jun 30, 2021
hex1848 pushed a commit to hex1848/opentelemetry-collector-contrib that referenced this pull request Jun 2, 2022
…etry#3880)

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.41.1 to 1.42.0.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.41.1...v1.42.0)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants