Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS X-Ray Exporter #41

Merged
merged 68 commits into from
Dec 16, 2019
Merged

Add AWS X-Ray Exporter #41

merged 68 commits into from
Dec 16, 2019

Conversation

kbrockhoff
Copy link
Member

Documentation is covered in README in awsxrayexporter directory. conn.go and X-ray_client.go were adapted from https://github.com/aws/aws-xray-daemon

owais
owais reviewed Nov 20, 2019
View reviewed changes
Copy link
Contributor

@owais owais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick first pass and added some comments. I see a lot of debug/info statements which suggests this is probably still WIP and not ready for review? Feel free to ignore comments for now if that is the case but please add WIP to the title.

cmd/otelcontribcol/components.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/config.go Show resolved Hide resolved
exporter/awsxrayexporter/conn.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/conn.go Show resolved Hide resolved
exporter/awsxrayexporter/conn.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/testdata/config.yaml Outdated Show resolved Hide resolved
exporter/awsxrayexporter/translator/aws.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/translator/aws.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/translator/cause.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/translator/writer_pool.go Show resolved Hide resolved
tigrannajaryan
tigrannajaryan requested changes Nov 21, 2019
View reviewed changes
cmd/otelcontribcol/components.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/awsxray.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/conn.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/conn.go Outdated Show resolved Hide resolved
@tigrannajaryan tigrannajaryan mentioned this pull request Nov 26, 2019
Merged
tigrannajaryan
tigrannajaryan reviewed Nov 26, 2019
View reviewed changes
exporter/awsxrayexporter/config.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/config_test.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/conn.go Show resolved Hide resolved
exporter/awsxrayexporter/conn.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/translator/cause.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/translator/http.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/translator/http.go Outdated Show resolved Hide resolved
exporter/awsxrayexporter/translator/segment.go Outdated Show resolved Hide resolved
@kbrockhoff
initial dev of xray data structures and converters
22c2ae6
@kbrockhoff
initial dev of xray data structures and converters
73e2541
@kbrockhoff
initial dev of xray data structures and converters
b6b1198
@kbrockhoff
initial dev of xray data structures and converters
42435c8
@kbrockhoff
initial dev of export handler
b6c606b
@kbrockhoff
fix formatting and lint errors
4f0086a
@kbrockhoff
initial dev of export handler
3fb89a0
@kbrockhoff
added to component list
56623ed
@kbrockhoff
fix issues raised during code review
42a3d06
@kbrockhoff
switch user attribute name to constant
34442e6
@kbrockhoff
fixed additional code review issues
2b6a513
@kbrockhoff
fixed additional code review issues
30566de
@kbrockhoff
temporarily change package name
142de99
@kbrockhoff
temporarily change package name
101ea0e
@kbrockhoff
revert temporarily change package name
5989f2b
@kbrockhoff
fixed additional code review issues
935e60c
@kbrockhoff
switched to constants defined in collector
6f86a33
@kbrockhoff
switched to status conversion functions defined in collector
47c88e2
@kbrockhoff
fix latest code review issues
3915e0f
@kbrockhoff
fix new static check issues
ddc4777
@kbrockhoff
fix test that breaks if no valid aws session available
e76baa4
@kbrockhoff
fix pull request issues
2ae696b
@kbrockhoff
Merge branch 'master' of github.com:kbrockhoff/opentelemetry-collecto…
ef18288 
…r-contrib
@pjanotti pjanotti merged commit 2b856d9 into open-telemetry:master Dec 16, 2019
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector-contrib that referenced this pull request Dec 16, 2019
Revert "Add AWS X-Ray Exporter (open-telemetry#41)"
ed7f3f8 
This reverts commit 2b856d9.
tigrannajaryan added a commit that referenced this pull request Dec 16, 2019
@tigrannajaryan
Revert "Add AWS X-Ray Exporter (#41)" (#72)
1e0d031 
This reverts commit 2b856d9.
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
@rghetia
Add Circle ci (#41)
20b2f71 
* fix compile errors.

* fix lint errors.

* add circle-ci job.

* rename IDHigh to TraceIDHigh

* rename the file.

* add go get for goimports and golangci-lint

* enable GO111MODULE and remove comments.

* remove working dir and update cache name

* Add TEST_RESULT env back.

* run go mod tidy.

* remove go mod download.

* add test coverage.

* fix TraceID.

* fix circlefi config error.

* remove install-tools.

* remove ALL_TEST_SRC from Makefile.
prashant-shahi referenced this pull request in prashant-shahi/opentelemetry-collector-contrib Aug 2, 2022
@ankitnayan
Merge pull request #41 from SigNoz/fix/gRPC-materialized
4372431 
fix: add gRPC columns to materialized view
edma2 pushed a commit to edma2/opentelemetry-collector-contrib that referenced this pull request Oct 3, 2024
@edma2
[ACTION REQUIRED][Workday Migration] Update team name (open-telemetry#41
50d307d 
)

Co-authored-by: kube-gen-refactorator <infrastructure.service-orchestration@airbnb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rghetia rghetia rghetia approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@flands flands Awaiting requested review from flands

@pjanotti pjanotti Awaiting requested review from pjanotti

@songy23 songy23 Awaiting requested review from songy23

@owais owais Awaiting requested review from owais

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kbrockhoff @tigrannajaryan @rghetia @owais @pjanotti