-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[receiver/oracledb] Adding 'oracledb.logons' metric #41067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…fix broken code owners
@@ -387,3 +387,13 @@ metrics: | |||
value_type: int | |||
input_type: string | |||
unit: "{executions}" | |||
oracledb.logons: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we ever possible can have oracledb.logon.<something else>
metric, this should be oracledb.logon.count
. If not, this name is good.
See https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/naming.md#naming-rules-for-counters-and-updowncounters for more guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might add the following metrics later (based on v$statname
):
oracledb.user_logons
: only user logons operations (subset oforacledb.logons
which counts also the background processes)oracledb.current_logons
: current number of logons to the DB
Both are count metrics. I can't imagine any non-count metrics in this namespaces. But let me know if you nevertheless prefer a separate namespace with count
, e.g. oracledb.logon.count
.
SQL> select name from v$statname where name like '%logon%';
NAME
----------------------------------------------------------------
logons cumulative
logons current
user logons cumulative
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
Please address the conflict and mark ready for review again. |
…1067) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds the `oracledb.logons` metric to track logon operations. Logons can be costly and, in large numbers, may lead to CPU spikes and processing delays. I wrote more about this scenario [here](https://nenadnoveljic.com/blog/estimating-db-time-with-ash-logon-storm-pitfall/) (optional read): --------- Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
…1067) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adds the `oracledb.logons` metric to track logon operations. Logons can be costly and, in large numbers, may lead to CPU spikes and processing delays. I wrote more about this scenario [here](https://nenadnoveljic.com/blog/estimating-db-time-with-ash-logon-storm-pitfall/) (optional read): --------- Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
Description
Adds the
oracledb.logons
metric to track logon operations. Logons can be costly and, in large numbers, may lead to CPU spikes and processing delays. I wrote more about this scenario here (optional read):