Skip to content

[chore][pkg/ottl]: drop duplicate interface ProfileContext #41275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

florianl
Copy link
Contributor

@florianl florianl commented Jul 14, 2025

Description

Package ctxprofile exposed two interfaces, Context and ProfileContext, with the same functionality. Align package ctxprofile with other ctx signal packages by only exposing the Context interface and dropping ProfileContext.

…ace ProfileContext

Package ctxprofile exposed two interfaces, Context and ProfileContext, with the same functionality. Align package ctxprofile with other ctx signal packages by only exposing the Context interface and dropping ProfileContext.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@edmocosta edmocosta changed the title [chore][pkg/ottl/contexts/internal/ctxprofile]: drop duplicate interf… [chore][pkg/ottl]: drop duplicate interface ProfileContext Jul 14, 2025
@atoulme
Copy link
Contributor

atoulme commented Jul 16, 2025

No API changelog needed?

@florianl
Copy link
Contributor Author

No API changelog needed?

The change is in an internal subpackage, see path of the changed file pkg/ottl/contexts/internal/ctxprofile/profile.go, and not exposed in any way.

@atoulme atoulme merged commit 6e70350 into open-telemetry:main Jul 17, 2025
177 checks passed
Dylan-M pushed a commit to Dylan-M/opentelemetry-collector-contrib that referenced this pull request Aug 5, 2025
…lemetry#41275)

#### Description

Package ctxprofile exposed two interfaces, Context and ProfileContext,
with the same functionality. Align package ctxprofile with other ctx
signal packages by only exposing the Context interface and dropping
ProfileContext.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants