-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Testbed #51
Merged
pjanotti
merged 2 commits into
open-telemetry:master
from
tigrannajaryan:feature/tigran/add-test-bed
Dec 9, 2019
Merged
Introduce Testbed #51
pjanotti
merged 2 commits into
open-telemetry:master
from
tigrannajaryan:feature/tigran/add-test-bed
Dec 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported Testbed from Collector core repo and added one perf test from core scenarios to demonstrate that the testbed works. The plan is to add tests for other protocols in this contrib repo using the Testbed.
tigrannajaryan
requested review from
bogdandrutu,
flands,
owais,
pjanotti,
rghetia and
songy23
as code owners
December 9, 2019 17:24
pjanotti
approved these changes
Dec 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one Q about the possibility of using some Makefile defs from Makefile.Common
owais
approved these changes
Dec 9, 2019
pjanotti
approved these changes
Dec 9, 2019
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
mxiamxia
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 22, 2020
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
follow issue #51
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
* Change entry.Labels to entry.Attributes
jj22ee
pushed a commit
to jj22ee/opentelemetry-collector-contrib
that referenced
this pull request
Sep 21, 2023
…nhnanced-metrics2 do not emit enhanced metrics unless we are already emitting control plane metrics
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported Testbed from Collector core repo and added one perf
test from core scenarios to demonstrate that the testbed works.
The plan is to add tests for other protocols in this contrib repo
using the Testbed.