Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove squash on configtls.TLSClientSetting for splunkhecexporter #5541

Merged

Conversation

hyunuk
Copy link
Contributor

@hyunuk hyunuk commented Oct 1, 2021

Description:
This PR removes squash onconfigtls.TLSClientSetting and update corresponding yaml file for splunkhecexporter.
See history here

Link to tracking Issue:
#5433

@hyunuk hyunuk requested review from a team and djaglowski October 1, 2021 01:31
@bogdandrutu
Copy link
Member

Please rebase

@tigrannajaryan
Copy link
Member

@hyunuk Please resolve the merge conflict.

…ontrib into remove_squash_configtls_splunk
…ontrib into remove_squash_configtls_splunk
@hyunuk
Copy link
Contributor Author

hyunuk commented Oct 6, 2021

@hyunuk Please resolve the merge conflict.

@tigrannajaryan Done! took longer than expected due to the consistent test failure.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tigrannajaryan tigrannajaryan merged commit 7fecacb into open-telemetry:main Oct 6, 2021
dmitryax added a commit to signalfx/splunk-otel-collector-chart that referenced this pull request Oct 20, 2021
dmitryax added a commit to signalfx/splunk-otel-collector-chart that referenced this pull request Oct 20, 2021
dmitryax added a commit to signalfx/splunk-otel-collector-chart that referenced this pull request Oct 20, 2021
dmitryax added a commit to signalfx/splunk-otel-collector-chart that referenced this pull request Oct 20, 2021
dmitryax added a commit to signalfx/splunk-otel-collector-chart that referenced this pull request Oct 20, 2021
dmitryax added a commit to signalfx/splunk-otel-collector-chart that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants