-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove squash on configtls.TLSClientSetting for splunkhecexporter #5541
Merged
tigrannajaryan
merged 7 commits into
open-telemetry:main
from
open-o11y:remove_squash_configtls_splunk
Oct 6, 2021
Merged
fix: remove squash on configtls.TLSClientSetting for splunkhecexporter #5541
tigrannajaryan
merged 7 commits into
open-telemetry:main
from
open-o11y:remove_squash_configtls_splunk
Oct 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovieStoreGuy
approved these changes
Oct 1, 2021
Please rebase |
…ontrib into remove_squash_configtls_splunk
dmitryax
approved these changes
Oct 4, 2021
@hyunuk Please resolve the merge conflict. |
…ontrib into remove_squash_configtls_splunk
6 tasks
…ontrib into remove_squash_configtls_splunk
@tigrannajaryan Done! took longer than expected due to the consistent test failure. |
tigrannajaryan
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
dmitryax
added a commit
to signalfx/splunk-otel-collector-chart
that referenced
this pull request
Oct 20, 2021
Cover all configuration interface changes: - open-telemetry/opentelemetry-collector-contrib#5384 - open-telemetry/opentelemetry-collector-contrib#5541 - open-telemetry/opentelemetry-collector-contrib#5840
dmitryax
added a commit
to signalfx/splunk-otel-collector-chart
that referenced
this pull request
Oct 20, 2021
Cover all configuration interface changes: - open-telemetry/opentelemetry-collector-contrib#5384 - open-telemetry/opentelemetry-collector-contrib#5541 - open-telemetry/opentelemetry-collector-contrib#5840
dmitryax
added a commit
to signalfx/splunk-otel-collector-chart
that referenced
this pull request
Oct 20, 2021
Cover all configuration interface changes: - open-telemetry/opentelemetry-collector-contrib#5384 - open-telemetry/opentelemetry-collector-contrib#5541 - open-telemetry/opentelemetry-collector-contrib#5840
dmitryax
added a commit
to signalfx/splunk-otel-collector-chart
that referenced
this pull request
Oct 20, 2021
Cover all upstream configuration interface changes: - open-telemetry/opentelemetry-collector-contrib#5384 - open-telemetry/opentelemetry-collector-contrib#5541 - open-telemetry/opentelemetry-log-collection#262
dmitryax
added a commit
to signalfx/splunk-otel-collector-chart
that referenced
this pull request
Oct 20, 2021
Cover all upstream configuration interface changes: - open-telemetry/opentelemetry-collector-contrib#5384 - open-telemetry/opentelemetry-collector-contrib#5541 - open-telemetry/opentelemetry-log-collection#262
dmitryax
added a commit
to signalfx/splunk-otel-collector-chart
that referenced
this pull request
Oct 20, 2021
Cover all upstream configuration interface changes: - open-telemetry/opentelemetry-collector-contrib#5384 - open-telemetry/opentelemetry-collector-contrib#5541 - open-telemetry/opentelemetry-log-collection#262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes squash on
configtls.TLSClientSetting
and update corresponding yaml file for splunkhecexporter.See history here
Link to tracking Issue:
#5433