Add sfx receiver

[pjanotti]

Add a receiver supporting SignalFx metrics.

[tigrannajaryan]

How about sfxDataPoint.Properties field? Do we ignore this? I think this corresponds to Resource attributes (I may be wrong).

[pjanotti]

The type that I'm using is from proto and it doesn't have Properties:

type DataPoint struct {
	Source           *string      `protobuf:"bytes,1,opt,name=source" json:"source,omitempty"`
	Metric           *string      `protobuf:"bytes,2,opt,name=metric" json:"metric,omitempty"`
	Timestamp        *int64       `protobuf:"varint,3,opt,name=timestamp" json:"timestamp,omitempty"`
	Value            *Datum       `protobuf:"bytes,4,opt,name=value" json:"value,omitempty"`
	MetricType       *MetricType  `protobuf:"varint,5,opt,name=metricType,enum=com.signalfx.metrics.protobuf.MetricType" json:"metricType,omitempty"`
	Dimensions       []*Dimension `protobuf:"bytes,6,rep,name=dimensions" json:"dimensions,omitempty"`
	XXX_unrecognized []byte       `json:"-"`
}

I assume that Properties that you mention comes from the client lib, let me see what it is translated to.

[tigrannajaryan]

OK, ignore this.

Looks like it was removed from Protobuf definition signalfx/com_signalfx_metrics_protobuf@5e41ba1

I just had an old version of SmartAgent source code which was refering to the version of the Protobuf which had this field.

However, this makes it unclear to me how are resource attributes reported? Dimensions are supposedly the identity of the metric, i.e. the label keys. Where do resource attributes like hostname go? Also in Dimensions?

[pjanotti]

I found Properties on the event type:

type Event struct {
	EventType        *string        `protobuf:"bytes,1,req,name=eventType" json:"eventType,omitempty"`
	Dimensions       []*Dimension   `protobuf:"bytes,2,rep,name=dimensions" json:"dimensions,omitempty"`
	Properties       []*Property    `protobuf:"bytes,3,rep,name=properties" json:"properties,omitempty"`
	Category         *EventCategory `protobuf:"varint,4,opt,name=category,enum=com.signalfx.metrics.protobuf.EventCategory" json:"category,omitempty"`
	Timestamp        *int64         `protobuf:"varint,5,opt,name=timestamp" json:"timestamp,omitempty"`
	XXX_unrecognized []byte         `json:"-"`
}

[tigrannajaryan]

Perhaps check with SFx folks.

[tigrannajaryan]

Please rebase and resolve the conflicts.