Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created in Error: Ignore #6340

Closed
wants to merge 59 commits into from
Closed

Created in Error: Ignore #6340

wants to merge 59 commits into from

Conversation

boostchicken
Copy link
Member

@boostchicken boostchicken commented Nov 16, 2021 •
edited
Loading

IGNORE

@boostchicken
First cut
d03caa3
@boostchicken
Merge branch 'main' into datadog-receiver
a8336eb
@boostchicken
Updating implementation to 0.26
ea3785c
@boostchicken
Small convention updates
9578d10
@boostchicken
Added tests
aebe6d4
@boostchicken
Added tests
9e8e5f6
@boostchicken
README.md
9787ee4
@boostchicken
obs cleanup
52f19a5
@boostchicken
Moved to Datadog v05 code
45c9ddc
@boostchicken
Modified translator with new api code
479c331
@boostchicken
Code cleanup
57b1d7b
@boostchicken
Code cleanup
d4da3d2
@boostchicken
Code cleanup
a7e76f0
@boostchicken
Code cleanup
ffab5c0
@boostchicken
Refactor decode request
3ffc8c7
@boostchicken
Refactor decode request
975c80a
@boostchicken
Refactor decode request
4dbf2fc
@boostchicken
Refactor server lifecycle
4dfefbc
@boostchicken
Refactor server spankind
ebbdb86
@boostchicken
Moved translation engine and fixed translator
9f41cb8
@boostchicken
Moved translation engine and fixed translator
d248319
@boostchicken
Added resource
e3d9d21
@boostchicken
More todos
db1dc04
@boostchicken
More todos
b15002d
@boostchicken
More todos
d7b097e
@boostchicken
More todos
6a16963
@boostchicken
More todos
d41b80e
@boostchicken
Format cleanup
331d70c
@boostchicken
Basic Translator Benchmark test
8023ee1
@boostchicken
Correct trace id creation
b025439
boostchicken and others added 14 commits November 5, 2021 06:04
@boostchicken
Removing Span name assumption from DD exporter now that there is re-m…
bdc6d3b 
…apping
@boostchicken
Removing Span name assumption from DD exporter now that there is re-m…
dbf045e 
…apping
@boostchicken
Reverting translate traces
7705838
@boostchicken
Code cleanup, ILS information pulled from DD Headers
ab290d1
@boostchicken
Code cleanup, ILS information pulled from DD Headers
d378ec7
@boostchicken @mx-psi
Update receiver/datadogreceiver/translator.go
b278461 
Error exists syntax sanity

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
@boostchicken
Merge branch 'main' into datadog-receiver
04813d2 
# Conflicts:
#	go.mod
#	go.sum
@boostchicken @mx-psi
Update receiver/datadogreceiver/receiver.go
e0b0c7e 
Fixing printf formatting

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
@boostchicken
Resolving issues brought up by code reviews
49125d5
@boostchicken
Merge branch 'datadog-receiver' of https://github.com/boostchicken/op…
23ae86f 
…entelemetry-collector-contrib into datadog-receiver
@boostchicken
gotidy for datadogreceiver
569ee58
@boostchicken
Documenting readtimeout
41ddce7
@boostchicken
Adding unit test to translator, go.sum, go.mod tidying
8d5a5e0
@boostchicken
Add ability to filter spans
b6800f2
@boostchicken boostchicken requested review from a team and kbrockhoff November 16, 2021 08:51
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 16, 2021 •
edited
Loading

CLA Not Signed

  • ❌ - John Dorman The commit (d03caa3 ,a8336eb33d1471d9559b01ce463e064a6132a7bb ,ea3785c1fb07a350f43fcc18be6f85357e27f7f4 ,9578d1036cda7d2b98dd76ecffe1778e73dfc212 ,aebe6d4e9be54e55e902807a4406223b9753dbce ,9e8e5f6f6fb976634fc09b2f644233527018a1eb ,9787ee4e8218ad4d4118aca51acdd23d7c3e5d5c ,52f19a5c5e9d47d24f7b1064290932cd8cd9d75b ,45c9ddc4ef11409071c21f2be0afc3b1d65a6b85 ,479c331cf527998476e7f4f1e4a2ea142652f9d6 ,57b1d7b71182c4365ea0074756f78bcf11d29549 ,d4da3d2cac31e623ef1f2a1dc3a13d69a5dbccc0 ,a7e76f0cb62cb0b8aea1c24a4f14bfa670bbb961 ,ffab5c0a4ef7d85a05a45329a8e15379136ec74e ,3ffc8c768d9d31e0e8f10df777b0591c6131ac47 ,975c80a1a5ae274203b47144b5bfa32b09973418 ,4dbf2fc9382a0db89b6d27b38fe6701813278e5e ,4dfefbcc22b963036816125dfb90b52459570590 ,ebbdb862cd2caff2856c326b8614acea87b4f19f ,9f41cb8b9887dcfcd61dcac66dd245b29e75540b ,d24831979f0b1f701cbff053e5e5bf556bbe5f28 ,e3d9d21cac5221120b24408ab794c0c072cc785c ,db1dc04ccaa288e7e326b618037f198fe90256ab ,b15002d1fac4ba9185f2c63d17115a0c89e9c561 ,d7b097e07766d64eafa754333b71df0648c3efc4 ,6a16963e23146fcaad8d6f56c35730f875a6645f ,d41b80e6dd29a1ee1a5ed2d12ac91e54dd72928b ,331d70cf0a1019398d5ffefd31b1addc02d41124 ,8023ee137edc538a993237651bccac582f0a9514 ,b025439ebcf023b96e80524d9c3d7fe6b60dc4e0 ,34842b4194bbf24ebab4119acb2e68d466da931a ,82fef4e7a333d0209cf020c2e5c3509d66460fd1 ,9ab035abb540efb4b555de14181f569dfba7db11 ,cec1d5e892c34e996c3e033425d00d0c175dc917 ,d2a5ac98b7cb0f32d5097aa1a3996400d19610ca ,29cf7232d7b597c62b378174a20d6a231176ca60 ,93bdc4fd0404c3e14ebb1ee99fac8770de976505 ,82aa15ea6c4e4fc863bda362a961f5738bca0a7d ,75461be3c08354c534667b860679f736f15e03c8 ,76a2dd62faea141303219faf2107580a1483e39b ,9994d6ac2d4dc6ad99123d0101f6032912c0cc47 ,0ca2ddcb3842d8b684eb8b272e043b196121d195 ,2c9979fa39ede2a8f483280d4592bc0870bdd390 ,6c123b0d63415b371349daf0459afdc63c6c3742 ,f3d147a2a2329dc5b63286be58171ff5a2091d74 ,bdc6d3b6e4209ff010db82d17dafec955944d99b ,dbf045eea68db192a777308befd0ced29d0cb98f ,77058387814143addb9b35e828202ebf51dbd5aa ,ab290d104de910d37b5e69c440340453004b5013 ,d378ec701eecb774a40cd54f89df940797adef27 ,b2784617151cba09f1bf6cd054291bd5064ebe19 ,04813d20576e7f19226022fb05699b94831de89c ,e0b0c7e848c886e787af8b82e390994ec9e734b9 ,49125d54c91e70e47103d51be36b6359d55e4769 ,23ae86f04cf9997d0fc5ca1bb95ef31d5970cb3e ,569ee58c513877654a0667fe957d66190a888891 ,41ddce7dd26e61c08ddf026f360d46b224d10717 ,8d5a5e0d6dea4093fb2c1eb1e7cf719831e686cb ,b6800f2c4125e8320953eb70268e473e2b7bb7d8) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

@boostchicken boostchicken changed the title Filter traces processor/filterprocessor: Ability to filter Spans Nov 16, 2021
@boostchicken
Copy link
Member Author

closing PR, branched off wrong base

@boostchicken boostchicken deleted the filter_traces branch November 16, 2021 10:18
@boostchicken boostchicken restored the filter_traces branch November 27, 2021 12:32
@boostchicken boostchicken reopened this Nov 27, 2021
@codeboten
Copy link
Contributor

@boostchicken is this PR superseeded by #6341? The description suggests its the same PR

@boostchicken
Copy link
Member Author

Yeah this shoud be closed.

@boostchicken boostchicken deleted the filter_traces branch December 4, 2021 07:39
@boostchicken boostchicken changed the title processor/filterprocessor: Ability to filter Spans Created in Error: Ignore Dec 4, 2021
povilasv referenced this pull request in coralogix/opentelemetry-collector-contrib Dec 19, 2022
@bogdandrutu
Deprecate New[JSON|Proto][Marshaler|Unmarshale], expose the structs (#…
bb193a2 
…6340)

The main motivation is because we want to be able to extend these Marshaler/Unmarshaler implementation with possible options.

Because of that we have 2 options: 1. add Option to each New func, OR 2. expose the structs so that later users can configure different options inside these structs, similar with `jsonpb.Marshaler`.

I implemented the version 2 since it is simpler, and less code, and also common in the industry.

Signed-off-by: Bogdan <bogdandrutu@gmail.com>

Signed-off-by: Bogdan <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbrockhoff kbrockhoff Awaiting requested review from kbrockhoff

Assignees

@bogdandrutu bogdandrutu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boostchicken @codeboten @bogdandrutu