[processor/spanmetrics] use LRU cache for metricKeyToDimensions
#6503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenzhihao
changed the title
metricKeyToDimensionsmetricKeyToDimensions
chenzhihao
force-pushed
the
OBC-259_LRU
branch
2 times, most recently
from
81caa62
to
0ac8a38
Compare
chenzhihao
commented
Dec 6, 2021
chenzhihao
force-pushed
the
OBC-259_LRU
branch
from
e4f6af4
to
5b0bc7f
Compare
chenzhihao
changed the title
metricKeyToDimensionsmetricKeyToDimensions
Tenaria
reviewed
Dec 6, 2021
Tenaria
reviewed
Dec 6, 2021
Tenaria
reviewed
Dec 6, 2021
jamesmoessis
reviewed
Dec 6, 2021
|
lgtm |
jamesmoessis
reviewed
Dec 6, 2021
|
Another thing, why is the name of the PR |
chenzhihao
changed the title
metricKeyToDimensionsmetricKeyToDimensions
chenzhihao
force-pushed
the
OBC-259_LRU
branch
from
0fa4224
to
e6018b3
Compare
MovieStoreGuy
approved these changes
Dec 14, 2021
|
There seem to be merge conflicts for this PR. |
|
Hey @jpkrohling , it should be ready to be merged now. Thanks! |
albertteoh
reviewed
Dec 15, 2021
Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com>
Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com>
Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com>
Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com>
jpkrohling
changed the title
metricKeyToDimensionsmetricKeyToDimensions
|
Once the last points are sorted out, ping me again to review/merge this one. |
jpkrohling
approved these changes
Dec 16, 2021
|
@jpkrohling Could you please merge it? Thanks. |
CoderPoet
reviewed
Jan 4, 2022
| m, err := p.buildMetrics() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // Firstly, export metrics to avoid being impacted by downstream trace processor errors/latency. | ||
| if err := p.metricsExporter.ConsumeMetrics(ctx, *m); err != nil { |
There was a problem hiding this comment.
Why not consider periodic build and consume metric here?
Each trace goes to export metrics ( for example: remote write、otlp exporter ), will the cost be slightly higher?
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
* prepare release 0.64.0 * Prepare stable for version v0.64.0 * Prepare beta for version v0.64.0 * add multimod changes * changelog entries Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a feature - use LRU cache for
metricKeyToDimensions. Hence its memory usage will be boundedLink to tracking Issue:
It partially addresses the issue: #2179
Testing:
New unit tests for the cache implementation.
Existing unit tests are updated to verify existing processing logic is still as expected.
Documentation:
The usage of
metric_key_to_dimensions_cache_sizeconfiguration field is added in README.md