-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/couchdb] Initialize component #6815
Merged
bogdandrutu
merged 10 commits into
open-telemetry:main
from
observIQ:couchdbreceiver-establish-codebase
Dec 16, 2021
Merged
[receiver/couchdb] Initialize component #6815
bogdandrutu
merged 10 commits into
open-telemetry:main
from
observIQ:couchdbreceiver-establish-codebase
Dec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWamsley
changed the title
Couchdbreceiver establish codebase
Add Couchdbreceiver factory and config
Dec 15, 2021
jpkrohling
changed the title
Add Couchdbreceiver factory and config
[receiver/couchdb] Initialized component
Dec 16, 2021
jpkrohling
changed the title
[receiver/couchdb] Initialized component
[receiver/couchdb] Initialize component
Dec 16, 2021
djaglowski
reviewed
Dec 16, 2021
@JonathanWamsley Please resolve the conflict in |
Co-authored-by: Daniel Jaglowski <dan.jaglowski@bluemedora.com>
JonathanWamsley
force-pushed
the
couchdbreceiver-establish-codebase
branch
from
December 16, 2021 18:40
7204ee0
to
0f1d67e
Compare
I rebased my branch onto main to resolve the versions conflict @djaglowski |
@JonathanWamsley please fix |
djaglowski
approved these changes
Dec 16, 2021
djaglowski
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Dec 16, 2021
bogdandrutu
approved these changes
Dec 16, 2021
This was referenced Dec 16, 2021
6 tasks
animetauren
pushed a commit
to animetauren/opentelemetry-collector-contrib
that referenced
this pull request
Apr 4, 2023
…n persistent storage (open-telemetry#6815) Fix a data loss bug occuring in persistent queue when otel collector restart. When otel collector restart, the retry_sender will mark a request as finished and cause persistent storage to remove it from currentlyDispatchedItems. This causes data loss. This change propagates an interrupted error when shutdown is called. The error propagates to the consumer callback function and each consumer can determine action against the error. The persistent storage is updated to check and ensure those requests are not marked as finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the config and factory for a Couchdb metric receiver.
Testing:
Wrote unit tests for config and factory files.