Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/couchdb] Initialize component #6815

Merged

Conversation

JonathanWamsley
Copy link
Contributor

Description:
This PR adds the config and factory for a Couchdb metric receiver.

Testing:
Wrote unit tests for config and factory files.

@JonathanWamsley JonathanWamsley requested review from a team and djaglowski December 15, 2021 15:45
@JonathanWamsley JonathanWamsley changed the title Couchdbreceiver establish codebase Add Couchdbreceiver factory and config Dec 15, 2021
@jpkrohling jpkrohling changed the title Add Couchdbreceiver factory and config [receiver/couchdb] Initialized component Dec 16, 2021
@jpkrohling jpkrohling changed the title [receiver/couchdb] Initialized component [receiver/couchdb] Initialize component Dec 16, 2021
receiver/couchdbreceiver/README.md Outdated Show resolved Hide resolved
receiver/couchdbreceiver/config.go Outdated Show resolved Hide resolved
@djaglowski
Copy link
Member

@JonathanWamsley Please resolve the conflict in versions.yaml. Looks good otherwise

@JonathanWamsley JonathanWamsley force-pushed the couchdbreceiver-establish-codebase branch from 7204ee0 to 0f1d67e Compare December 16, 2021 18:40
@JonathanWamsley
Copy link
Contributor Author

I rebased my branch onto main to resolve the versions conflict @djaglowski

@djaglowski
Copy link
Member

@JonathanWamsley please fix versions.yaml

@djaglowski djaglowski added the ready to merge Code review completed; ready to merge by maintainers label Dec 16, 2021
animetauren pushed a commit to animetauren/opentelemetry-collector-contrib that referenced this pull request Apr 4, 2023
…n persistent storage (open-telemetry#6815)

Fix a data loss bug occuring in persistent queue when otel collector restart.
When otel collector restart, the retry_sender will mark a request as finished and cause persistent storage to remove it from currentlyDispatchedItems. This causes data loss.

This change propagates an interrupted error when shutdown is called. The error propagates to the consumer callback function and each consumer can determine action against the error. The persistent storage is updated to check and ensure those requests are not marked as finished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants