[receiver/elasticsearch] Implement Client #7019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryFissionGames
changed the title
djaglowski
reviewed
Jan 4, 2022
receiver/elasticsearchreceiver/testdata/sample_payloads/health.json
Outdated
Show resolved
Hide resolved
|
I think this looks good, but please rebase. |
BinaryFissionGames
force-pushed
the
elasticsearchreceiver-client
branch
from
7786aaa
to
d228031
Compare
|
@djaglowski Rebased; I can see the changelog causing more friction with these PRs as time goes on here, since that seems to change a lot now. |
Yes, #6924 is tracking this concern. Ultimately, there seems to be a tradeoff between developer experience and user experience (from the changelog omitting important changes). Ideally, a solution would be identified that solves for both concerns, but none has been articulated yet. |
djaglowski
approved these changes
Jan 6, 2022
djaglowski
added
the
ready to merge
vincentfree
added a commit
to vincentfree/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2022
* add elasticsearchexporter to the components exporter list * update elastic version * [exporter/kafka] Allow configuring the acknowledgement behaviour (open-telemetry#6301) * feat(exporter/kafka): allow configuring the acknowledgement behaviour * doc(exporter/kafka): add additional context to the RequiredAcks parameter * chore(exporter/kafka): validate RequiredAcks option * chore(container.image.name): add changelog entry * [mdatagen] Clarify some comments in metadata.yaml schema (open-telemetry#6976) * [receiver/k8scluster] Remove included tags (open-telemetry#6436) * feat(container.image.name): remove tags included in the name and introduce helper package * fix(container.image.name): use `` instead "" for regex * docs(Changelog): add changes * chore(container.image.name): rename function to ParseImageName * chore(container.image.name): add logging for parse failures * feat(container.image.name): use struct to encapsulate return value * feat(container.image): add sha256 field * chore(container.image.name): implement change requests * [internal/components] Add all extensions to lifecycle tests (open-telemetry#6934) * Adding all extensions to the lifecycle test * Updating test to use correct methods * [internal/components] Add all receivers to lifecycle tests (open-telemetry#6974) * Adding in existing receivers into the test suite * Making the receivers testable * Disabling windows test * Fixing windows tests * [receiver/influxdb] Update success write response code (open-telemetry#6530) * update influx success write response as 204 Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com> * update influx receiver readme Signed-off-by: Jeeva Kandasamy <jkandasa@gmail.com> * Update receiver/influxdbreceiver/README.md Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> * [processor/routing] Fix wrong array config in example (open-telemetry#6984) ref: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/processor/routingprocessor/config.go#L29 * [exporter/skywalking] Add skywalking metrics exporter (open-telemetry#6528) * incorperate new elasticsearch version * [processor/deltatorate] Add int counter support (open-telemetry#6982) * processor/deltatorateprocessor: add int counter support (open-telemetry#6981) Signed-off-by: Jimmie Han <hanjinming@outlook.com> * simplify switch case Signed-off-by: Jimmie Han <hanjinming@outlook.com> * add changelog Signed-off-by: Jimmie Han <hanjinming@outlook.com> * switch case default return error Signed-off-by: Jimmie Han <hanjinming@outlook.com> * Update prometheus exec receiver build comments (open-telemetry#6911) * [exporter/loki] Log the first part of the http body on failed pushes to loki (open-telemetry#6946) * Log the first part of the http body on failed pushes to loki The body includes important information about the reason for the error. This is based on the promtail implementation https://github.com/grafana/loki/blob/bd1fef08a8ea99e73a30c4739cfeb931353700e6/clients/pkg/promtail/client/client.go#L390 * Add CHANGELOG entry * [receiver/windowsperfcounters] Change counters to perfcounters in documentation (open-telemetry#7001) * dependabot updates Tue Jan 4 08:08:07 PST 2022 (open-telemetry#7004) Bump github.com/shirou/gopsutil/v3 from 3.21.11 to 3.21.12 in /testbed Bump actions/setup-go from 2.1.4 to 2.1.5 Bump github.com/open-telemetry/opentelemetry-log-collection from 0.23.0 to 0.24.0 in /receiver/tcplogreceiver Bump github.com/shirou/gopsutil/v3 from 3.21.11 to 3.21.12 in /exporter/signalfxexporter Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.316 to 1.0.323 in /exporter/tencentcloudlogserviceexporter Bump github.com/aws/aws-sdk-go from 1.42.23 to 1.42.25 in /receiver/awscontainerinsightreceiver Bump github.com/shirou/gopsutil/v3 from 3.21.11 to 3.21.12 in /extension/fluentbitextension Bump github.com/aws/aws-sdk-go from 1.42.23 to 1.42.25 in /exporter/datadogexporter Bump github.com/shirou/gopsutil/v3 from 3.21.11 to 3.21.12 in /extension/observer/hostobserver Bump github.com/open-telemetry/opentelemetry-log-collection from 0.23.0 to 0.24.0 in /receiver/journaldreceiver Bump github.com/open-telemetry/opentelemetry-log-collection from 0.23.0 to 0.24.0 in /receiver/syslogreceiver Bump github.com/open-telemetry/opentelemetry-log-collection from 0.23.0 to 0.24.0 in /receiver/filelogreceiver Bump github.com/open-telemetry/opentelemetry-log-collection from 0.23.0 to 0.24.0 in /internal/stanza Bump github.com/aws/aws-sdk-go from 1.42.23 to 1.42.25 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.42.23 to 1.42.25 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go from 1.42.23 to 1.42.25 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.42.23 to 1.42.25 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.42.23 to 1.42.25 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go from 1.42.23 to 1.42.25 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.42.23 to 1.42.25 in /internal/aws/xray Bump github.com/DataDog/agent-payload/v5 from 5.0.7 to 5.0.8 in /exporter/datadogexporter Bump github.com/DataDog/datadog-agent/pkg/quantile from 0.32.3 to 0.32.4 in /exporter/datadogexporter Bump github.com/getsentry/sentry-go from 0.11.0 to 0.12.0 in /exporter/sentryexporter Bump github.com/aws/aws-sdk-go from 1.42.23 to 1.42.25 in /internal/aws/xray/testdata/sampleapp * Add djaglowski as code owner on extention/storage/filestorage (open-telemetry#7018) * Bump actions/setup-go from 2.1.4 to 2.1.5 (open-telemetry#6953) Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2.1.4 to 2.1.5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2.1.4...v2.1.5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add documentation for default values. (open-telemetry#7022) * Fix issue where zookeeper receiver could panic during shutdown. (open-telemetry#7020) When the zookeeper receiver is started, and then stopped before the scrape function is ever called, it does not yet have a cancel function to call. There was previously an expectation that this cancel function existed by the time shutdown was called. This change protects against the scenario where it does not yet exist. * dependabot updates Tue Jan 4 15:24:53 PST 2022 (open-telemetry#7024) Bump github.com/fluent/fluent-logger-golang from 1.8.0 to 1.9.0 in /testbed Bump github.com/aws/aws-sdk-go from 1.42.25 to 1.42.26 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.42.25 to 1.42.26 in /exporter/awsprometheusremotewriteexporter Bump github.com/aws/aws-sdk-go from 1.42.25 to 1.42.26 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go from 1.42.25 to 1.42.26 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.42.25 to 1.42.26 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.42.25 to 1.42.26 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.42.25 to 1.42.26 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go from 1.42.25 to 1.42.26 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.42.25 to 1.42.26 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.42.25 to 1.42.26 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.42.25 to 1.42.26 in /internal/aws/xray/testdata/sampleapp * fix: drop a metric if it has a staleness flag (open-telemetry#6977) * [receiver/redis] Set start timestamp uniformly for gauge and sum metrics (open-telemetry#6941) Currently start time of gauge metrics is set to 0. According to the specification https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/datamodel.md#gauge, start time should be set the timestamp when a metric collection system started. The time when redis server started is already being used for Sum metrics. There is no reason to keep it inconsistent. This change applies the same timestamp value to both Gauge and Sum metrics uniformly. * [receiver/couchdb] Implement client (open-telemetry#6880) * establish couchdb codebase * add in pr feedback * add couchdb client * clean up names/format * fix linting ci * add couchdbreceiver to verisons * update with pr feedback * establish couchdb codebase * add in pr feedback * clean up names/format * fix linting ci * add couchdbreceiver to verisons * remove host validation * fix nit * Update receiver/couchdbreceiver/README.md Co-authored-by: Daniel Jaglowski <dan.jaglowski@bluemedora.com> * add check for default endpoint on CreateDefaultConfig * add missing receivers in versions * change Nodes struct to nodes * update client pr feedback * update changelog * update client tests w/ default config Co-authored-by: Daniel Jaglowski <dan.jaglowski@bluemedora.com> * dependabot updates Wed Jan 5 09:37:36 PST 2022 (open-telemetry#7052) Bump go.uber.org/zap from 1.19.1 to 1.20.0 in /exporter/kafkaexporter Bump go.uber.org/zap from 1.19.1 to 1.20.0 in /exporter/awscloudwatchlogsexporter Bump go.uber.org/zap from 1.19.1 to 1.20.0 in /internal/aws/proxy Bump go.uber.org/zap from 1.19.1 to 1.20.0 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.42.25 to 1.42.27 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /exporter/awsprometheusremotewriteexporter Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /extension/observer/ecsobserver Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /exporter/awscloudwatchlogsexporter Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.42.26 to 1.42.27 in /internal/aws/xray/testdata/sampleapp * fix metadata fetching when metrics have suffixes (open-telemetry#6932) * [receiver/prometheusexec] Remove keitwb as codeowner (open-telemetry#7003) * [receiver/prometheusexec] Remove keitwb as codeowner Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Remove keitwb as codeowner of statsd Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Add dmitryax to prom exec receiver and statsd Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Bump github.com/go-playground/validator/v10 in /cmd/mdatagen (open-telemetry#7054) Bumps [github.com/go-playground/validator/v10](https://github.com/go-playground/validator) from 10.9.0 to 10.10.0. - [Release notes](https://github.com/go-playground/validator/releases) - [Commits](go-playground/validator@v10.9.0...v10.10.0) --- updated-dependencies: - dependency-name: github.com/go-playground/validator/v10 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * address logging issues (open-telemetry#7021) * address logging issues Adding a package to support sanitizing data consistently across components. The first method is `sanitize.URL` to address issues around logging URLs directly. * fix lint * fix impi * rename variable * disable docker_stats lifecycle for receivers test (open-telemetry#7056) * Update core to latest in preparation for this week release (open-telemetry#7057) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [receiver/prometheus] set pdata stale marker (open-telemetry#7043) * receiver/prometheus: set no-data-present flag when stale NaN found Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * [exporter/signalfx] Don't use `syscall` to avoid compilation errors (open-telemetry#7062) syscall is deprecated and doesn't guarantee compatibility with all platforms. This change replaces usages of syscall with sys/unix package to avoid compilation errors on some specific platforms. * Organize replace directives in root and cmd/configschema go.mod's (open-telemetry#7067) This change is intended to have no effect, other than improving developer experience. * Fix prometheus job cache exiration by using the longest scrape interval (open-telemetry#7053) Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> * Remove Owais Lone from the approvers' list (open-telemetry#7066) Owais is currently not able to allocate much time to the Collector. Thank you for your contributions, Owais. I hope to see you back when you have more time! * [receiver/elasticsearch] Implement Client (open-telemetry#7019) * implement Elasticsearch client * Add status to cluster health struct * add jvm uptime to nodestats * remove unused sample payload (for now) * Allow client to specify nodes to get stats from * add empty nodes check, add test for nil/empty nodes * go mod tidy * minor wording tweaks * add in max heap mem to nodestats model * changelog * fix lint errors * addlicense * re-order imports in client.go * make porto * add newline to sample health payload * fix disjoint client error handling * take in config struct for client creation * omitempty on IOStats * add header to request 7.x compatible response * take ownership of Prometheus exporters (open-telemetry#7068) Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * [receiver/redis] Apply new mdatagen metrics builder (open-telemetry#6938) This change migrates redis receiver to use new mdatagen metrics builder. There is no functional change on the metrics output except for reordering. * Upgrade containerd to fix high severity security issue (open-telemetry#7069) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update core deps to prepare for release (open-telemetry#7073) Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * Prepare v0.42.0 release (open-telemetry#7074) * Update module version for v0.42.0 release * Update internal dependency versions Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com> * [Datadog] Span naming option to use OTel semantic convention (open-telemetry#6611) * open-telemetry#1909 Added an option to use span name as datadog resource name. * open-telemetry#1909 - Added if statement to change the resource name in Datadog exporter. - Fixed tests * Added test case to the new option in datadog exporter. * open-telemetry#1909 Added readme description of the option. * open-telemetry#1909 Change configuration place. * open-telemetry#1909 Added option to config example. * Removed boolean option from function. Added test to cover option use. * Linted test code. * Added entry to changelog. * Update exporter/datadogexporter/example/config.yaml Co-authored-by: Alex Boten <alrex.boten@gmail.com> * [processor/transform] Add skeleton for query language transform processor (open-telemetry#7047) * Query language transform processor * Tweak README * Fix imports * Setup PR1 * More details about span transformation * lint * Rename keep -> keep_keys * Traces conig * english * [cicd] stop publishing artifacts in this repo (open-telemetry#7083) The artifacts for collector contrib are now published in the releases repo: https://github.com/open-telemetry/opentelemetry-collector-releases. * Propose @dashpole as approver (open-telemetry#7088) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * [receiver/couchdb] Define metrics (open-telemetry#6878) * establish couchdb codebase establish couchdb metadata metrics add metadata metrics update units establish couchdb codebase clean up names/format add couchdbreceiver to verisons remove host validation fix nit add check for default endpoint on CreateDefaultConfig add missing receivers in versions update versions end space update metadata pr feedback remove enum for http.method/status_code add code gen experimental tag, failed, bug issue made update metadata to include enable * update changelog * update metrics to value_type int * update nit changes * update metadata names * add view attribute * [receiver/fluentforward] Convert attributes with nil value to AttributeValueTypeEmpty (open-telemetry#6630) * [fluentforwardreceiver] Handle attributes with nil value Attributes with a nil value are currently being converted to the string "<nil>" Instead, they should be converted to AttributeValueTypeEmpty * Add CHANGELOG entry * dependabot updates Fri Jan 7 13:55:57 PST 2022 (open-telemetry#7111) Bump github.com/honeycombio/libhoney-go from 1.15.6 to 1.15.8 in /exporter/honeycombexporter Bump cloud.google.com/go from 0.99.0 to 0.100.2 in /processor/resourcedetectionprocessor Bump google.golang.org/api from 0.63.0 to 0.64.0 in /exporter/googlecloudexporter Bump google.golang.org/api from 0.63.0 to 0.64.0 in /exporter/f5cloudexporter Bump google.golang.org/api from 0.63.0 to 0.64.0 in /receiver/googlecloudspannerreceiver Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /receiver/awscontainerinsightreceiver Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /processor/resourcedetectionprocessor Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /exporter/kafkaexporter Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /exporter/awskinesisexporter Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /exporter/awsprometheusremotewriteexporter Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /receiver/awsxrayreceiver Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /exporter/datadogexporter Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /exporter/awscloudwatchlogsexporter Bump cloud.google.com/go/spanner from 1.28.0 to 1.29.0 in /receiver/googlecloudspannerreceiver Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /exporter/awsemfexporter Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /extension/observer/ecsobserver Bump github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common from 1.0.323 to 1.0.326 in /exporter/tencentcloudlogserviceexporter Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /internal/aws/proxy Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /exporter/awsxrayexporter Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /internal/aws/k8s Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /internal/aws/xray Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /internal/aws/awsutil Bump github.com/aws/aws-sdk-go from 1.42.27 to 1.42.30 in /internal/aws/xray/testdata/sampleapp Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com> Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com> Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com> Co-authored-by: Jeeva Kandasamy <jkandasa@gmail.com> Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de> Co-authored-by: Jared Tan <jian.tan@daocloud.io> Co-authored-by: liqiangz <liqiang.zjhz@gmail.com> Co-authored-by: Jimmie Han <hanjinming@outlook.com> Co-authored-by: Mrod1598 <miguel.rodriguez@observiq.com> Co-authored-by: gregoryfranklin <45693481+gregoryfranklin@users.noreply.github.com> Co-authored-by: Tamir Michaeli <tamir.michaeli@logz.io> Co-authored-by: Alex Boten <aboten@lightstep.com> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hyunuk Lim <dev.hyunuk@gmail.com> Co-authored-by: Jon <jonathan.wamsley@bluemedora.com> Co-authored-by: Daniel Jaglowski <dan.jaglowski@bluemedora.com> Co-authored-by: David Ashpole <dashpole@google.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Ryan Fitzpatrick <rmfitzpatrick@users.noreply.github.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Anthony Mirabella <a9@aneurysm9.com> Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com> Co-authored-by: Brandon Johnson <brandon.johnson@bluemedora.com> Co-authored-by: gfonseca-tc <93946129+gfonseca-tc@users.noreply.github.com> Co-authored-by: Alex Boten <alrex.boten@gmail.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
animetauren
pushed a commit
to animetauren/opentelemetry-collector-contrib
that referenced
this pull request
Apr 4, 2023
…er (open-telemetry#7019) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Testing: