Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeletstats receiver: do not break down metrics batch #754

Merged

Conversation

dmitryax
Copy link
Member

Do not break down metrics batch before sending to the downstream

Resolves: #703

@dmitryax dmitryax requested a review from a team August 18, 2020 06:56
@dmitryax dmitryax force-pushed the kubeletstats-receiver-remove-loop branch from acc003b to cce779f Compare August 18, 2020 18:46
@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #754 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   87.42%   87.43%           
=======================================
  Files         210      210           
  Lines       11430    11430           
=======================================
+ Hits         9993     9994    +1     
+ Misses       1095     1094    -1     
  Partials      342      342           
Flag Coverage Δ
#integration 72.09% <ø> (ø)
#unit 87.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ceiver/kubeletstatsreceiver/kubelet/accumulator.go 100.00% <100.00%> (ø)
receiver/kubeletstatsreceiver/kubelet/metrics.go 100.00% <100.00%> (ø)
receiver/kubeletstatsreceiver/runnable.go 100.00% <100.00%> (ø)
receiver/kubeletstatsreceiver/kubelet/pb.go 88.05% <0.00%> (-2.99%) ⬇️
receiver/carbonreceiver/transport/tcp_server.go 68.57% <0.00%> (+2.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee7578...26129b2. Read the comment docs.

@bogdandrutu
Copy link
Member

Please rebase

@dmitryax dmitryax force-pushed the kubeletstats-receiver-remove-loop branch from cce779f to fea0303 Compare August 18, 2020 21:20
@bogdandrutu
Copy link
Member

Fix the CI?

Do not break down metrics batch before sending to the downstream
@dmitryax dmitryax force-pushed the kubeletstats-receiver-remove-loop branch from fea0303 to 26129b2 Compare August 18, 2020 22:34
@dmitryax
Copy link
Member Author

@bogdandrutu fixed

@bogdandrutu bogdandrutu merged commit 8183bd9 into open-telemetry:master Aug 19, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
Added setting of span attribute "span.kind" to "internal" when translating from OTLP to OC and translate back to SpanKindINTERNAL when translating from OC to OTLP.

**Link to tracking Issue:** #1136 #754

**Testing:** All tracing correctness tests involving only otlp and opencensus receivers and exporters now report a zero failure count.
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
Replace sdktrace.WithResourceAttributes() with WithResource()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid unnecessary loop in kubeletstats receiver runner
2 participants