[exporter/datadog] Add support for delta exponential histograms #8350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSerrania
force-pushed
the
kserrania/exponentialhistogram
branch
2 times, most recently
from
887006a to
de2deb1
Compare
KSerrania
force-pushed
the
kserrania/exponentialhistogram
branch
from
de2deb1 to
f654ed7
Compare
mx-psi
reviewed
Mar 10, 2022
exporter/datadogexporter/internal/model/translator/exponential_histograms_translator.go
Outdated
Show resolved
Hide resolved
exporter/datadogexporter/internal/model/translator/exponential_histograms_translator.go
Outdated
Show resolved
Hide resolved
exporter/datadogexporter/internal/model/translator/exponential_histograms_translator_test.go
Show resolved
Hide resolved
exporter/datadogexporter/internal/model/translator/exponential_histograms_translator_test.go
Outdated
Show resolved
Hide resolved
mx-psi
reviewed
Mar 10, 2022
|
There are a bunch of conflicts that need to be solved here |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
If you mark it as ready for review, I think we can mark this as ready to merge 🎉 |
mx-psi
added
the
ready to merge
codeboten
reviewed
May 5, 2022
codeboten
approved these changes
May 6, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…-telemetry#8350) * [WIP] Add ExponentialHistogram support * Do not support cumulative expHists for now * Add unit tests * Update go.mod / go.sum * Fix rebase conflicts * Add MapMetrics tests * Fix go mod tidy errors * Update github.com/DataDog/datadog-agent/pkg/quantile * Refactor store creation in toStore method * Refactor tests to use public MapMetrics function * Add benchmarks * Update DataDog/datadog-agent/pkg/quantile version
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds support for exporting delta exponential histograms as sketches to Datadog. The conversion is done as follows:
ExponentialHistogram -> DDSketch (done here by copying the buckets, with the same scale)
DDSketch -> Agent Sketch (done by
github.com/DataDog/datadog-agent/pkg/quantile, in this PR)Optionally, the count and sum of the exponential histogram can also be sent as metrics. This behavior is managed by the
histograms.send_count_sum_metrics(the same that is used for histograms - should it be a different one?).Cumulative histograms are left out for now (they'll require more involved changes, notably to compute the diff between two exponential histograms) and will be done in a later PR.
Note: this PR currently used unreleased versions of
github.com/DataDog/sketches-goandgithub.com/DataDog/datadog-agent/pkg/quantilethat will be released at a later date. Once this happens, the go.mod should point to released versions.Link to tracking Issue: n/a
Testing: Added unit tests, as well as benchmarks for gauges, delta sums and delta exponential histograms, for comparison purposes.
Documentation: n/a