[exporter/datadog] Deprecate automatic environment variable detection #8397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't really do this with the full struct without introducing public API that will have to be deleted later. Since we don't plan to add more environment variables, I think this way of doing the test is also okay.
albertvaka
reviewed
Mar 14, 2022
albertvaka
approved these changes
Mar 15, 2022
anuraaga
approved these changes
Mar 15, 2022
mx-psi
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecate automatic environment variable detection, targeting removal at v0.50.
Link to tracking Issue: #8396
Testing: There is no easy way to add unit tests for this, so I manually tested this by
Documentation: Environment variable auto-detection has been marked as deprecated in the documentation.