-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/sigv4authextension] Enable component #8518
[extension/sigv4authextension] Enable component #8518
Conversation
Looks like I need to run |
The dependency can be found on the official Go proxy (you can download it here https://proxy.golang.org/github.com/go-chi/chi/v4/@v/v4.0.0-rc1.zip) but not on Github (https://github.com/go-chi/chi/releases/tag/v4.0.0-rc1 returns a 404). You are probably not using the official Go proxy (what does I will try to report this upstream and also to our APM tracer team (I work at Datadog) so that this doesn't happen. |
Reported at DataDog/dd-trace-go#1188 (comment) and go-chi/chi#713 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember that to include this on the binaries you have to make a PR on the releases repo, see e.g. open-telemetry/opentelemetry-collector-releases#78 I see you already did that 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't seem to create a PR to your branch @erichsueh3, but here's the gotidy
change: codeboten@5b76e2d
We cannot access the official Go proxy, so I consider us canaries for bad modules! :) |
Tried the suggested change to set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a changelog entry
Description:
Enables the
sigv4authextension
component