[receiver/riak] Riak Metric Receiver #8548

armstrmi · 2022-03-17T17:30:02Z

Description: Adding New Component: Riak Metric Receiver,

Link to tracking Issue: New Component: Riak Metric Receiver

Testing: series of testing was added including

config_test.go
client_test.go
scraper_test.go
factory_test.go
As well as sample configs for running local riak receiver and verify that metrics are being received

Documentation: README.md

djaglowski

Overall looks quite good. A few things need another look though.

We also need to add an integration test like this one.

receiver/riakreceiver/README.md

receiver/riakreceiver/metadata.yaml

receiver/riakreceiver/scraper.go

receiver/riakreceiver/testdata/apiresponses/get_stats_response.json

receiver/riakreceiver/internal/models/models.go

receiver/riakreceiver/internal/model/model.go

receiver/riakreceiver/metadata.yaml

receiver/riakreceiver/go.mod

receiver/riakreceiver/integration_test.go

receiver/riakreceiver/internal/model/model.go

djaglowski

Please add this module to the CODEOWNERS file with the two of us listed as owners.

receiver/riakreceiver/README.md

receiver/riakreceiver/client_test.go

receiver/riakreceiver/metadata.yaml

receiver/riakreceiver/scraper.go

receiver/riakreceiver/scraper_test.go

receiver/riakreceiver/config_test.go

receiver/riakreceiver/internal/model/model.go

djaglowski

Please add the component to the root go.mod (include a replace directive) and also cmd/configschema tests.

djaglowski · 2022-03-28T16:19:02Z

@armstrmi CI is still failing on this:

-package riakreceiver
+package riakreceiver // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/riakreceiver"
 
 import (
 	"context"
Porto links are out of date, please run "make goporto" and commit the changes in this PR.
Error: Process completed with exit code 1.

djaglowski · 2022-03-28T17:58:45Z

Generated code is out of date, please run "make generate" and commit the changes in this PR.
Error: Process completed with exit code 1.

djaglowski · 2022-03-29T18:26:00Z

👍 The integration test is running successfully:

make[2]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/riakreceiver'
running go integration test ./... + coverage in /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/riakreceiver
go: downloading github.com/open-telemetry/opentelemetry-collector-contrib/internal/scrapertest v0.47.0
go: downloading go.opentelemetry.io/otel v1.5.0
go: downloading go.opentelemetry.io/otel/trace v1.5.0
go: downloading github.com/docker/docker v20.10.11+incompatible
go: downloading github.com/go-logr/logr v1.2.2
go: downloading google.golang.org/protobuf v1.27.1
=== RUN   TestRiakIntegration
2022/03/29 15:43:26 Starting container id: 7a[713](https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/5741948997?check_suite_focus=true#step:7:713)83af5d7 image: testcontainers/ryuk:0.3.3
2022/03/29 15:43:26 Waiting for container id 7a71383af5d7 image: testcontainers/ryuk:0.3.3
2022/03/29 15:43:26 Container is ready id: 7a71383af5d7 image: testcontainers/ryuk:0.3.3
2022/03/29 15:44:10 Starting container id: 76ec36cf280c image: fd[730](https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/5741948997?check_suite_focus=true#step:7:730)e39-81f1-49f9-b737-8ad62c6435ad:d6f37d0a-607f-42f0-a59d-f91cc9b4019e
2022/03/29 15:44:10 Waiting for container id 76ec36cf280c image: fd730e39-81f1-49f9-b737-8ad62c6435ad:d6f37d0a-607f-42f0-a59d-f91cc9b4019e
2022/03/29 15:44:14 Container is ready id: 76ec36cf280c image: fd730e39-81f1-49f9-b737-8ad62c6435ad:d6f37d0a-607f-42f0-a59d-f91cc9b4019e
--- PASS: TestRiakIntegration (56.54s)
PASS
coverage: 68.5% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/riakreceiver	56.604s	coverage: 68.5% of statements
?   	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/riakreceiver/internal/metadata	[no test files]
?   	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/riakreceiver/internal/mocks	[no test files]
?   	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/riakreceiver/internal/model	[no test files]
make[2]: Leaving directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/riakreceiver'

djaglowski

LGTM. Thanks @armstrmi!

jpkrohling · 2022-03-30T15:17:34Z

I'm waiting on the new release to be performed before merging this. It would probably cause this PR to get outdated (like, the changelog and go.mod/sum).

anuraaga · 2022-03-30T16:15:04Z

I appreciate the thumbs up from the contributors but I definitely wish that maintainers instead took the effort to update existing PRs when they make changes that break them, including releases.

jpkrohling · 2022-03-31T11:11:23Z

I agree with you, @anuraaga. I think most of us are trying that, but there are cases where it's not possible/feasible. In this case, the release hasn't been made and I was about to leave for the day, but wanted to make it clear (also to other maintainers) that this wouldn't get merged before the release.

anuraaga · 2022-03-31T11:13:00Z

Cool sounds like the sentiment is there.

jpkrohling · 2022-03-31T11:15:32Z

Forgot another case where we can't do it (which is the case with this PR as well): if contributors don't mark the PR as "maintainers can change it", we can't add commits or force push a change to the PR. The best we can then do is push the branch to our own forks, and offer it to the contributor.

CHANGELOG.md

pmm-sumo

As @djaglowski noticed, changelog needs to be cleaned up from the duplicate entries

bogdandrutu · 2022-04-06T20:34:47Z

@djaglowski @jpkrohling do we have an issue for this?

Update: Saw the issue in the description. don't know how you folks can carefully review 5500 lines in a reasonable amount of time :)) probably you spent lots of time...

armstrmi · 2022-04-06T20:37:01Z

@bogdandrutu yes we do, #8364

djaglowski · 2022-04-06T22:16:25Z

don't know how you folks can carefully review 5500 lines in a reasonable amount of time :)) probably you spent lots of time...

It can easily be done in an unreasonable amount of time :)

More seriously, my strategy has been to approach it as multiple review sessions. Start with obvious issues / gaps. Then focus on config and data model. Then factory and scraper. Double check tests and coverage. Finally checking all minor details.

Necessary changes to address feedback were simple and clear and have been completed.

armstrmi requested review from a team and mx-psi March 17, 2022 17:30

github-actions bot assigned anuraaga Mar 17, 2022

armstrmi changed the title ~~New Component: Riak Metric Receiver~~ Riak Receiver Mar 17, 2022

armstrmi changed the title ~~Riak Receiver~~ [receiver/riak] Riak Metric Receiver Mar 17, 2022

djaglowski assigned djaglowski and unassigned anuraaga Mar 17, 2022

djaglowski reviewed Mar 17, 2022

View reviewed changes

djaglowski reviewed Mar 18, 2022

View reviewed changes

djaglowski reviewed Mar 22, 2022

View reviewed changes

receiver/riakreceiver/go.mod Outdated Show resolved Hide resolved

receiver/riakreceiver/integration_test.go Show resolved Hide resolved

receiver/riakreceiver/integration_test.go Outdated Show resolved Hide resolved

djaglowski reviewed Mar 22, 2022

View reviewed changes

receiver/riakreceiver/internal/model/model.go Outdated Show resolved Hide resolved

armstrmi force-pushed the riakreceiver branch from 5f88bd9 to 57ae42b Compare March 24, 2022 20:48

djaglowski reviewed Mar 25, 2022

View reviewed changes

receiver/riakreceiver/config_test.go Outdated Show resolved Hide resolved

receiver/riakreceiver/internal/model/model.go Outdated Show resolved Hide resolved

djaglowski reviewed Mar 25, 2022

View reviewed changes

armstrmi added 2 commits March 28, 2022 15:31

added functionality for riakreceiver

d769b1c

updated generate code

82558e9

armstrmi force-pushed the riakreceiver branch from 7498c20 to 82558e9 Compare March 28, 2022 21:05

armstrmi added 3 commits March 29, 2022 10:13

updated collector versions

e8e5fb7

Merge branch 'main' into riakreceiver

434f0ad

added riak to versioning

0e16921

djaglowski approved these changes Mar 29, 2022

View reviewed changes

djaglowski added the ready to merge Code review completed; ready to merge by maintainers label Mar 29, 2022

Merge branch 'main' into riakreceiver

4a873b0

djaglowski reviewed Apr 4, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

pmm-sumo previously requested changes Apr 5, 2022

View reviewed changes

armstrmi added 3 commits April 5, 2022 09:34

removed duplicate entries

20dad71

Merge branch 'main' into riakreceiver

26acf8c

updated otel collector versions

a33a268

djaglowski approved these changes Apr 5, 2022

View reviewed changes

Merge branch 'main' into riakreceiver

47c96d1

djaglowski requested a review from pmm-sumo April 6, 2022 19:45

djaglowski merged commit cd25661 into open-telemetry:main Apr 7, 2022

armstrmi mentioned this pull request Apr 7, 2022

REQUEST: New membership for armstrmri open-telemetry/community#1022

Closed

6 tasks

djaglowski mentioned this pull request Apr 9, 2022

New component: Riak Metric Receiver #8364

Closed

pmm-sumo mentioned this pull request Apr 11, 2022

[extension/filestorage] use correct bbolt options for compaction #9134

Merged

ahayworth mentioned this pull request May 16, 2022

Update to otel-contrib-col v0.51.0 Shopify/opentelemetry-collector-contrib#796

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[receiver/riak] Riak Metric Receiver #8548

[receiver/riak] Riak Metric Receiver #8548

armstrmi commented Mar 17, 2022

djaglowski left a comment

djaglowski left a comment

djaglowski left a comment

djaglowski commented Mar 28, 2022

djaglowski commented Mar 28, 2022

djaglowski commented Mar 29, 2022

djaglowski left a comment

jpkrohling commented Mar 30, 2022

anuraaga commented Mar 30, 2022

jpkrohling commented Mar 31, 2022

anuraaga commented Mar 31, 2022

jpkrohling commented Mar 31, 2022

pmm-sumo left a comment

bogdandrutu commented Apr 6, 2022 •

edited

Loading

armstrmi commented Apr 6, 2022

djaglowski commented Apr 6, 2022

[receiver/riak] Riak Metric Receiver #8548

[receiver/riak] Riak Metric Receiver #8548

Conversation

armstrmi commented Mar 17, 2022

djaglowski left a comment

Choose a reason for hiding this comment

djaglowski left a comment

Choose a reason for hiding this comment

djaglowski left a comment

Choose a reason for hiding this comment

djaglowski commented Mar 28, 2022

djaglowski commented Mar 28, 2022

djaglowski commented Mar 29, 2022

djaglowski left a comment

Choose a reason for hiding this comment

jpkrohling commented Mar 30, 2022

anuraaga commented Mar 30, 2022

jpkrohling commented Mar 31, 2022

anuraaga commented Mar 31, 2022

jpkrohling commented Mar 31, 2022

pmm-sumo left a comment

Choose a reason for hiding this comment

bogdandrutu commented Apr 6, 2022 • edited Loading

armstrmi commented Apr 6, 2022

djaglowski commented Apr 6, 2022

bogdandrutu commented Apr 6, 2022 •

edited

Loading