[exporter/signalfx] Fix correlation timeout bug #9101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcollins
approved these changes
Apr 6, 2022
|
Failing tests are unrelated to my changes |
crobert-1
changed the title
The SignalFx Exporter supports correlations between metrics and traces. This means that when a trace occurs from a given host, with dimensions like service and environment, these dimensions can be used to query metrics for these traces. These correlations are supposed to timeout after the stale_service_timeout amount of time passes, but they weren't. This fix makes sure correlations timeout so that metrics aren't linked with stale trace data.
- Add public type comment - Move implementing checker right under struct declaration - Add spaces between functions - Fix failing PR checks: Delay in tests failed in automation, add license block in test file.
GitHub automation was failing unit tests because of a race detected. The solution was to add a mutex to checking and setting the variable in question.
crobert-1
force-pushed
the
sfx_export_correlate_fix
branch
from
6e7f664 to
4016993
Compare
dmitryax
added
the
ready to merge
codeboten
approved these changes
Apr 12, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The SignalFx Exporter supports correlations between metrics and traces. This means that when a trace occurs from a given host, with dimensions like service and environment, these dimensions can be used to query metrics for these traces. These correlations are supposed to timeout after the stale_service_timeout amount of time passes, but they weren't. This fix makes sure correlations timeout so that metrics aren't linked with stale trace data.
Testing:
Manual testing is working as expected, but it's currently impossible (from my understanding) to write tests for this functionality. The problem is that the tests would need to create both metrics and traces to send to the signalfx backend, but at that high of a level the correlation values couldn't be properly checked, as they're not available outside the local package.