Fix featuregate for googlecloud exporter by not checking it during NewFactory #9116
+20
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
temp_featuregate_fix
branch
from
3727af3 to
7dd5e0b
Compare
aabmass
approved these changes
Apr 7, 2022
djaglowski
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to open-telemetry/opentelemetry-collector#4967. While we debate how to address featuregates not working during NewFactory, make the featuregate in the googlecloud exporter work correctly.
Description:
Check the
exporter.googlecloud.OTLPDirectfeaturegate during trace/metrics exporter creation, rather than factory creation.Testing:
Manually tested with print statements to ensure feature gate flags are respected.