Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependabot updates Mon Apr 11 14:30 PDT 2022 #9222

Merged
merged 2 commits into from
Apr 12, 2022
Merged

dependabot updates Mon Apr 11 14:30 PDT 2022 #9222

merged 2 commits into from
Apr 12, 2022

Conversation

dmitryax
Copy link
Member

No description provided.

@dmitryax dmitryax requested a review from a team April 11, 2022 21:32
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 11, 2022
@dmitryax
Copy link
Member Author

It fails due to go library issue open-telemetry/opentelemetry-go#2781 which should be resolved shortly

@Aneurysm9
Copy link
Member

@dmitryax New metrics release is shipped and should resolve the failures.

@dmitryax
Copy link
Member Author

Thanks @Aneurysm9. PR updated

@dmitryax dmitryax mentioned this pull request Apr 12, 2022
Merged
codeboten
codeboten approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmitryax

codeboten
codeboten reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lint failure:

 Error: internal/common/parser.go:122:26: cannot use ([]lexer.Rule literal) (value of type []lexer.Rule) as []lexer.SimpleRule value in argument to lexer.MustSimple (typecheck)
	lex := lexer.MustSimple([]lexer.Rule{

@dmitryax
Copy link
Member Author

@codeboten the lint issue is fixed

@codeboten codeboten merged commit 891b4b4 into open-telemetry:main Apr 12, 2022
@dmitryax dmitryax deleted the depupdata branch April 12, 2022 20:33
@ahayworth ahayworth mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@pmm-sumo pmm-sumo Awaiting requested review from pmm-sumo

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@anuraaga anuraaga Awaiting requested review from anuraaga

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@punya punya Awaiting requested review from punya

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@arminru arminru Awaiting requested review from arminru

@alolita alolita Awaiting requested review from alolita

Assignees

@pmm-sumo pmm-sumo

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitryax @Aneurysm9 @codeboten @pmm-sumo