-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/k8sattributesprocessor] Add RBAC rules documentation #9365
Merged
codeboten
merged 4 commits into
open-telemetry:main
from
thib92:doc-k8sattributesprocessor-rbac
Apr 22, 2022
Merged
[processor/k8sattributesprocessor] Add RBAC rules documentation #9365
codeboten
merged 4 commits into
open-telemetry:main
from
thib92:doc-k8sattributesprocessor-rbac
Apr 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmm-sumo
approved these changes
Apr 19, 2022
dmitryax
reviewed
Apr 20, 2022
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
dmitryax
approved these changes
Apr 21, 2022
pmm-sumo
added
ready to merge
Code review completed; ready to merge by maintainers
Skip Changelog
PRs that do not require a CHANGELOG.md entry
labels
Apr 22, 2022
I've seen similar changes to doc.go skipped the changelog in the past so added the label |
I wasn't aware of the |
I think that's always a good idea :) |
codeboten
approved these changes
Apr 22, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…-telemetry#9365) * Document `k8sattributesprocessor` RBAC rules * Be more precise on filters * Be more specific about what the example does * Apply suggestions from code review Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready to merge
Code review completed; ready to merge by maintainers
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add missing documentation on how to setup RBAC rules for the
k8sattributesprocessor
Link to tracking Issue: N/A
Testing: I've tested the documented RBAC rules in my deployment of the collector.
Documentation: This adds an example of RBAC permissions to give to the collector in order to have the
k8sattributesprocessor
work.