[exporter/datadog] The command should be /otelcol-contrib in the example
#9425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keisku
changed the title
/otelcol-contrib/otelcol-contrib in the example
mx-psi
reviewed
Apr 25, 2022
There was a problem hiding this comment.
👋 thanks for fixing this, this changed on v0.40.0, I think with the move of release operations to opentelemetry-collector-releases.
Since this is technically code that end-users run, would you mind adding a note on the CHANGELOG.md file documenting the fix? Thanks!
mx-psi
approved these changes
Apr 25, 2022
mx-psi
reviewed
Apr 25, 2022
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
mx-psi
added
the
ready to merge
jpkrohling
approved these changes
Apr 25, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…ample (open-telemetry#9425) * [exporter/datadog] Fix command in the example * pin version * update changelog * Update CHANGELOG.md Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The command in
exporter/datadogexporter/example/example_k8s_manifest.yamlshould be/otelcol-contribaccording to the Dockerfile.Facing the error when applying the existing example.
Link to tracking Issue:
Testing:
Documentation: