Add workflow for make gotidy CI check #9713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
reviewed
May 3, 2022
dashpole
approved these changes
May 3, 2022
djaglowski
approved these changes
May 3, 2022
bogdandrutu
approved these changes
May 4, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This adds a workflow check to make sure
make gotidyhas been run on a PR. Right now this command produces a diff onmainwhich is confusing as other PRs that run it will pull in unrelated changes (see #9679 (comment)). This hurts the effectiveness of this command as a way to conveniently update all related depsLink to tracking Issue:
Testing: Tested in damemi#457
Documentation: