Small performance and code improvements in signalfx translation #9737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid lots of small allocations, 1 for every data point by allocating 2 slices one for the objects, one for the pointers. * Avoid allocating a "base" data point only for name and type, create helper that is shared across all funcs. * Remove duplicate code for calculating dimension set in histogram conversion * Fix fragile code that was using for quantiles and buckets dimension `append(dims, newDim)`, which worked correctly only because the `cap(dims) == len(dims)`, hence it force a new allocation of the slice all the time instead of modifying the same memory. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
djaglowski
approved these changes
May 4, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2022
…-telemetry#9737) * Avoid lots of small allocations, 1 for every data point by allocating 2 slices one for the objects, one for the pointers. * Avoid allocating a "base" data point only for name and type, create helper that is shared across all funcs. * Remove duplicate code for calculating dimension set in histogram conversion * Fix fragile code that was using for quantiles and buckets dimension `append(dims, newDim)`, which worked correctly only because the `cap(dims) == len(dims)`, hence it force a new allocation of the slice all the time instead of modifying the same memory. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
append(dims, newDim), which worked correctly only because thecap(dims) == len(dims), hence it force a new allocation of the slice all the time instead of modifying the same memory.Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com