Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/googlecloud] Update googlecloud exporter dependency #9784

Closed
wants to merge 1 commit into from
Closed

[exporter/googlecloud] Update googlecloud exporter dependency #9784

wants to merge 1 commit into from

Conversation

igorpeshansky
Copy link

Description:

Update GCP dependency to pull in a few bug fixes.

@igorpeshansky igorpeshansky requested a review from a team May 6, 2022 21:26
djaglowski
djaglowski requested changes May 9, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears there are some failing checks related to the change.

@dashpole
Copy link
Contributor

dashpole commented May 9, 2022

(looks like it needs make gotidy run)

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 24, 2022
@djaglowski
Copy link
Member

It appears this PR needs the following:

  • Rebase
  • Run make gotidy
  • Resolve unit test failures for the exporter

@igorpeshansky
Copy link
Author

Subsumed by #9944.

@igorpeshansky igorpeshansky deleted the igorpeshansky-update-operations-go branch May 24, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski requested changes

@dashpole dashpole dashpole approved these changes

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@punya punya Awaiting requested review from punya

Assignees

@bogdandrutu bogdandrutu

Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igorpeshansky @dashpole @djaglowski @bogdandrutu