Fix based on PR comments

cmd/occollector/app/builder/exporters_builder.go

@@ -196,7 +196,7 @@ func (eb *ExportersBuilder) buildExporter(
 		exporter.stop = combineStopFunc(exporter.stop, stopFunc)
 	}
 
-	eb.logger.Info(fmt.Sprintf("Exporter %s is enabled.", config.Name()))
+	eb.logger.Info("Exporter is enabled.", zap.String("exporter", config.Name()))
 
 	return exporter, nil
 }
@@ -206,9 +206,7 @@ func typeMismatchErr(
 	requiredByPipeline *configmodels.Pipeline,
 	dataType configmodels.DataType,
 ) error {
-	return fmt.Errorf(
-		"pipeline %s is attached %s to exporter %s which does not support %s "+
-			"telemetry data produced by pipeline. Exporter will be detached from pipeline",
+	return fmt.Errorf("%s is a %s pipeline but has a %s which does not support %s",
 		requiredByPipeline.Name, dataType.GetString(),
 		config.Name(), dataType.GetString(),
 	)

cmd/occollector/app/builder/pipelines_builder.go

@@ -115,7 +115,7 @@ func (pb *PipelinesBuilder) buildPipeline(
 		}
 	}
 
-	pb.logger.Info(fmt.Sprintf("Pipeline %s enabled.", pipelineCfg.Name))
+	pb.logger.Info("Pipeline is enabled.", zap.String("pipelines", pipelineCfg.Name))
 
 	return &builtProcessor{tc, mc}, nil
 }

cmd/occollector/app/builder/receivers_builder.go

@@ -88,11 +88,12 @@ func (rcvs Receivers) StopAll() {
 // StartAll starts all receivers.
 func (rcvs Receivers) StartAll(logger *zap.Logger, asyncErrorChan chan<- error) error {
 	for cfg, rcv := range rcvs {
-		logger.Info(fmt.Sprintf("Receiver %s starting...", cfg.Name()))
+		logger.Info("Receiver is starting...", zap.String("receiver", cfg.Name()))
+
 		if err := rcv.Start(asyncErrorChan); err != nil {
 			return err
 		}
-		logger.Info(fmt.Sprintf("Receiver %s started.", cfg.Name()))
+		logger.Info("Receiver is started.", zap.String("receiver", cfg.Name()))
 	}
 	return nil
 }
@@ -197,17 +198,17 @@ func (rb *ReceiversBuilder) attachReceiverToPipelines(
 	if err != nil {
 		if err == factories.ErrDataTypeIsNotSupported {
 			return fmt.Errorf(
-				"receiver %s does not support %s but some pipelines that "+
-					"want to process %s are attached to the receiever",
+				"receiver %s does not support %s but it was used in a "+
+					"%s pipeline",
 				config.Name(),
 				dataType.GetString(),
 				dataType.GetString())
 		}
 		return fmt.Errorf("cannot create receiver %s", config.Name())
 	}
 
-	rb.logger.Info(fmt.Sprintf("Receiver %s is enabled for %s.",
-		config.Name(), dataType.GetString()))
+	rb.logger.Info("Receiver is enabled.",
+		zap.String("receiver", config.Name()), zap.String("datatype", dataType.GetString()))
 
 	return nil
 }

cmd/occollector/app/builder/receivers_builder_test.go

@@ -195,23 +195,23 @@ func testReceivers(
 	}
 }
 
-func TestReceiversBuilder_Error(t *testing.T) {
-	//config, err := configv2.LoadConfigFile(t, "testdata/pipelines_builder.yaml")
-	//require.Nil(t, err)
-	//
-	//// Corrupt the pipeline, change data type to metrics. We have to forcedly do it here
-	//// since there is no way to have such config loaded by LoadConfigFile, it would not
-	//// pass validation. We are doing this to test failure mode of PipelinesBuilder.
-	//pipeline := config.Pipelines["traces"]
-	//pipeline.InputType = configmodels.MetricsDataType
-	//
-	//exporters, err := NewExportersBuilder(zap.NewNop(), config).Build()
-	//
-	//// This should fail because "attributes" processor defined in the config does
-	//// not support metrics data type.
-	//_, err = NewPipelinesBuilder(zap.NewNop(), config, exporters).Build()
-	//
-	//assert.NotNil(t, err)
+func TestReceiversBuilder_DataTypeError(t *testing.T) {
+	config, err := configv2.LoadConfigFile(t, "testdata/pipelines_builder.yaml")
+	require.Nil(t, err)
+
+	// Make examplereceiver to "unsupport" trace data type.
+	receiver := config.Receivers["examplereceiver"]
+	receiver.(*configv2.ExampleReceiver).FailTraceCreation = true
+
+	// Build the pipeline
+	allExporters, err := NewExportersBuilder(zap.NewNop(), config).Build()
+	pipelineProcessors, err := NewPipelinesBuilder(zap.NewNop(), config, allExporters).Build()
+	receivers, err := NewReceiversBuilder(zap.NewNop(), config, pipelineProcessors).Build()
+
+	// This should fail because "examplereceiver" is attached to "traces" pipeline
+	// which is a configuration error.
+	assert.NotNil(t, err)
+	assert.Nil(t, receivers)
 }
 
 func TestReceiversBuilder_StartAll(t *testing.T) {

internal/configmodels/configmodels.go

@@ -134,12 +134,12 @@ type ReceiverSettings struct {
 	Endpoint string `mapstructure:"endpoint"`
 }
 
-// Name gets the exporter name.
+// Name gets the receiver name.
 func (rs *ReceiverSettings) Name() string {
 	return rs.NameVal
 }
 
-// SetName sets the exporter name.
+// SetName sets the receiver name.
 func (rs *ReceiverSettings) SetName(name string) {
 	rs.NameVal = name
 }

internal/configv2/example_factories.go

@@ -30,6 +30,12 @@ import (
 type ExampleReceiver struct {
 	configmodels.ReceiverSettings `mapstructure:",squash"` // squash ensures fields are correctly decoded in embedded struct
 	ExtraSetting                  string                   `mapstructure:"extra"`
+
+	// FailTraceCreation causes CreateTraceReceiver to fail. Useful for testing.
+	FailTraceCreation bool `mapstructure:"-"`
+
+	// FailMetricsCreation causes CreateTraceReceiver to fail. Useful for testing.
+	FailMetricsCreation bool `mapstructure:"-"`
 }
 
 // ExampleReceiverFactory is factory for ExampleReceiver.
@@ -64,7 +70,9 @@ func (f *ExampleReceiverFactory) CreateTraceReceiver(
 	cfg configmodels.Receiver,
 	nextConsumer consumer.TraceConsumer,
 ) (receiver.TraceReceiver, error) {
-	// Not used for this test, just return nil
+	if cfg.(*ExampleReceiver).FailTraceCreation {
+		return nil, factories.ErrDataTypeIsNotSupported
+	}
 	return &ExampleReceiverProducer{TraceConsumer: nextConsumer}, nil
 }
 
@@ -73,7 +81,9 @@ func (f *ExampleReceiverFactory) CreateMetricsReceiver(
 	cfg configmodels.Receiver,
 	nextConsumer consumer.MetricsConsumer,
 ) (receiver.MetricsReceiver, error) {
-	// Not used for this test, just return nil
+	if cfg.(*ExampleReceiver).FailMetricsCreation {
+		return nil, factories.ErrDataTypeIsNotSupported
+	}
 	return &ExampleReceiverProducer{MetricsConsumer: nextConsumer}, nil
 }