-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
allow regexp on attribute value if it is a string match spans on instrumentation library
- Loading branch information
1 parent
c8aac9e
commit 54454ff
Showing
11 changed files
with
467 additions
and
275 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| // Copyright The OpenTelemetry Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package filterhelper | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "strconv" | ||
|
|
||
| "go.opentelemetry.io/collector/consumer/pdata" | ||
| "go.opentelemetry.io/collector/internal/processor/filterconfig" | ||
| "go.opentelemetry.io/collector/internal/processor/filterset" | ||
| ) | ||
|
|
||
| type AttributesMatcher []AttributeMatcher | ||
|
|
||
| // AttributeMatcher is a attribute key/value pair to match to. | ||
| type AttributeMatcher struct { | ||
| Key string | ||
| // If both AttributeValue and StringFilter are nil only check for key existence. | ||
| AttributeValue *pdata.AttributeValue | ||
| // StringFilter is needed to match against a regular expression | ||
| StringFilter filterset.FilterSet | ||
| } | ||
|
|
||
| var errUnexpectedAttributeType = errors.New("unexpected attribute type") | ||
|
|
||
| func NewAttributesMatcher(config filterset.Config, attributes []filterconfig.Attribute) (AttributesMatcher, error) { | ||
| // Convert attribute values from mp representation to in-memory representation. | ||
| var rawAttributes []AttributeMatcher | ||
| for _, attribute := range attributes { | ||
|
|
||
| if attribute.Key == "" { | ||
| return nil, errors.New("error creating processor. Can't have empty key in the list of attributes") | ||
| } | ||
|
|
||
| entry := AttributeMatcher{ | ||
| Key: attribute.Key, | ||
| } | ||
| if attribute.Value != nil { | ||
| val, err := NewAttributeValueRaw(attribute.Value) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if config.MatchType == filterset.Regexp { | ||
| if val.Type() != pdata.AttributeValueSTRING { | ||
| return nil, fmt.Errorf( | ||
| "%s=%s for %q only supports STRING, but found %s", | ||
| filterset.MatchTypeFieldName, filterset.Regexp, attribute.Key, val.Type(), | ||
| ) | ||
| } | ||
|
|
||
| filter, err := filterset.CreateFilterSet([]string{val.StringVal()}, &config) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| entry.StringFilter = filter | ||
| } else { | ||
| entry.AttributeValue = &val | ||
| } | ||
| } | ||
|
|
||
| rawAttributes = append(rawAttributes, entry) | ||
| } | ||
| return rawAttributes, nil | ||
| } | ||
|
|
||
| // match attributes specification against a span/log. | ||
| func (ma AttributesMatcher) Match(attrs pdata.AttributeMap) bool { | ||
| // If there are no attributes to match against, the span/log matches. | ||
| if len(ma) == 0 { | ||
| return true | ||
| } | ||
|
|
||
| // At this point, it is expected of the span/log to have attributes because of | ||
| // len(ma) != 0. This means for spans/logs with no attributes, it does not match. | ||
| if attrs.Len() == 0 { | ||
| return false | ||
| } | ||
|
|
||
| // Check that all expected properties are set. | ||
| for _, property := range ma { | ||
| attr, exist := attrs.Get(property.Key) | ||
| if !exist { | ||
| return false | ||
| } | ||
|
|
||
| if property.StringFilter != nil { | ||
| value, err := attributeStringValue(attr) | ||
| if err != nil || !property.StringFilter.Matches(value) { | ||
| return false | ||
| } | ||
| } else if property.AttributeValue != nil { | ||
| if !attr.Equal(*property.AttributeValue) { | ||
| return false | ||
| } | ||
| } | ||
| } | ||
| return true | ||
| } | ||
|
|
||
| func attributeStringValue(attr pdata.AttributeValue) (string, error) { | ||
| switch attr.Type() { | ||
| case pdata.AttributeValueSTRING: | ||
| return attr.StringVal(), nil | ||
| case pdata.AttributeValueBOOL: | ||
| return strconv.FormatBool(attr.BoolVal()), nil | ||
| case pdata.AttributeValueDOUBLE: | ||
| return strconv.FormatFloat(attr.DoubleVal(), 'f', -1, 64), nil | ||
| case pdata.AttributeValueINT: | ||
| return strconv.FormatInt(attr.IntVal(), 10), nil | ||
| default: | ||
| return "", errUnexpectedAttributeType | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.