We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem? Please describe. Both Opencensus Receiver and Otlp Receiver have similar gRPC Server settings
opentelemetry-collector/receiver/opencensusreceiver/config.go
Lines 28 to 48 in a637b41
opentelemetry-collector/receiver/otlpreceiver/config.go
Lines 27 to 49 in a637b41
Describe the solution you'd like A clear and concise description of what you want to happen. Have a struct similar to GRPCSettings
opentelemetry-collector/config/configgrpc/configgrpc.go
Line 40 in a637b41
This would receiver the existing GRPCSettings to be renamed to GRPCClientSettings.
Additional context This is just a cleanup.
The text was updated successfully, but these errors were encountered:
Bump boto3 in /internal/buildscripts/packaging/release (open-telemetr…
eea4481
…y#1014) Bumps [boto3](https://github.com/boto/boto3) from 1.20.20 to 1.20.21. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.20.20...1.20.21) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Successfully merging a pull request may close this issue.
Is your feature request related to a problem? Please describe.
Both Opencensus Receiver and Otlp Receiver have similar gRPC Server settings
opentelemetry-collector/receiver/opencensusreceiver/config.go
Lines 28 to 48 in a637b41
opentelemetry-collector/receiver/otlpreceiver/config.go
Lines 27 to 49 in a637b41
These should be extracted into a common gRPC Server Setting to reduce duplicate logic and have it exposed for other Server connections.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Have a struct similar to GRPCSettings
opentelemetry-collector/config/configgrpc/configgrpc.go
Line 40 in a637b41
This would receiver the existing GRPCSettings to be renamed to GRPCClientSettings.
Additional context
This is just a cleanup.
The text was updated successfully, but these errors were encountered: