Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use most reasonable default config in E2E tests #1023

Closed
tigrannajaryan opened this issue May 26, 2020 · 1 comment
Closed

Use most reasonable default config in E2E tests #1023

tigrannajaryan opened this issue May 26, 2020 · 1 comment
Assignees
@ccaraman
Milestone
Backlog

Comments

@tigrannajaryan
Copy link
Member

Identify the default configuration and default recommended processors (memory ballast, memlimiter, batcher, queued_retry, etc) and use them in end-to-end tests.
@tigrannajaryan tigrannajaryan added feature request help wanted Good issue for contributors to OpenTelemetry Service to pick up and removed feature request labels May 26, 2020
@ccaraman ccaraman self-assigned this May 27, 2020
@tigrannajaryan tigrannajaryan removed the help wanted Good issue for contributors to OpenTelemetry Service to pick up label May 27, 2020
@tigrannajaryan tigrannajaryan mentioned this issue May 28, 2020
Closed
@kbrockhoff kbrockhoff mentioned this issue Jun 1, 2020
Merged
@flands flands added this to the Beta 0.4 milestone Jun 4, 2020
@pavolloffay
Copy link
Member

@tigrannajaryan are there any plans to support default configuration (memory ballast, memlimiter, batcher, queued_retry, healthcheck) in the standard distribution?

@flands flands modified the milestones: Beta 0.4, Beta 0.5 Jun 16, 2020
tigrannajaryan pushed a commit that referenced this issue Jun 17, 2020
@kbrockhoff
Generalize testbed and add trace translation correctness tests (#1062)
e3df9f3 
Extracted out TestResultsSummary (in testbed/testbed/results.go), DataProvider (in testbed/testbed/data_provider.go), OtelcolRunner (in testbed/testbed/otelcol_runner.go), TestCaseValidator (in testbed/testbed/validator.go) interfaces with multiple implementations. Added tracing correctness tests in testbed/correctness using the testbed with different implementations of the 5 interfaces listed than what the perf tests use.

**Link to tracking Issue:** Provides the support to cleanly implement #652, #1022, #1023, #1027, #1031

**Testing:** All existing testbed-driven tests still pass. Correctness tests run without any panics. Correctness tests are reporting a number of bugs with translations.

**Documentation:** Godocs on all public methods.
@flands flands modified the milestones: Beta 0.5.0, Beta 0.5.1 Jul 6, 2020
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this issue Jul 13, 2020
@kbrockhoff @wyTrivail
Generalize testbed and add trace translation correctness tests (open-…
874ade0 
…telemetry#1062)

Extracted out TestResultsSummary (in testbed/testbed/results.go), DataProvider (in testbed/testbed/data_provider.go), OtelcolRunner (in testbed/testbed/otelcol_runner.go), TestCaseValidator (in testbed/testbed/validator.go) interfaces with multiple implementations. Added tracing correctness tests in testbed/correctness using the testbed with different implementations of the 5 interfaces listed than what the perf tests use.

**Link to tracking Issue:** Provides the support to cleanly implement open-telemetry#652, open-telemetry#1022, open-telemetry#1023, open-telemetry#1027, open-telemetry#1031

**Testing:** All existing testbed-driven tests still pass. Correctness tests run without any panics. Correctness tests are reporting a number of bugs with translations.

**Documentation:** Godocs on all public methods.
@flands flands modified the milestones: Beta 0.6.0, Beta 0.7.0 Jul 15, 2020
@bogdandrutu bogdandrutu modified the milestones: Beta 0.7.0, Beta 0.8.0, GA 1.0 Jul 30, 2020
@tigrannajaryan tigrannajaryan modified the milestones: GA 1.0, Backlog Oct 2, 2020
@alolita alolita closed this as completed Sep 2, 2021
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@ThomsonTan
Prepare for releasing 1.0.1 (open-telemetry#1023)
cfb02da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ccaraman ccaraman

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@flands @bogdandrutu @alolita @tigrannajaryan @pavolloffay @ccaraman