Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't spawn Collector process for certain E2E tests #1024

Closed
tigrannajaryan opened this issue May 26, 2020 · 3 comments
Closed

Don't spawn Collector process for certain E2E tests #1024

tigrannajaryan opened this issue May 26, 2020 · 3 comments

Comments

@tigrannajaryan
Copy link
Member

E2E tests today spawn a separate Collector process. This is useful for performance tests and certain other classes of tests (e.g. verifying the behavior after restarting from crash).

However many other E2E tests, such as verifying correctness of end-to-end operation of the Collector starting from receiving data, processing it, then exporting it do not necessarily require a separate process and can be run as regular Go tests.

We want ability to run full instance of the Collector Service, configurable similar to how testbed does it (with Data Senders and Receivers) but which do not run Collector executable as separate process.

This will speed up the test execution and will allow to have E2E test results in total coverage reports.

@tigrannajaryan
Copy link
Member Author

@flands I am removing this from this milestone since we won't have time to do it. Will be done later.

@tigrannajaryan tigrannajaryan removed this from the Beta 0.4 milestone Jun 4, 2020
@kbrockhoff
Copy link
Member

I have this working in my generalize-testbed branch. It just needs some polish. Please assign this ticket to me.

@kbrockhoff
Copy link
Member

This is fixed by PR #1062

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
…y#1024)

* Add regexp filter in api/label, test

* Add regexp option to sdk.Config

* Return indistinct values only when keyRe != nil

* Filter in sdk

* Add an accumulator filter test

* SDK tests pass

* Precommit

* Undo set filters

* Backout related filter changes

* Add a new test

* Fix build

* Apply suggestions from code review

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>

* Update comments

* Apply suggestions from code review

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants