Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporterhelper] Reconsider the need of Go API related to ObsReport #10592

Closed
dmitryax opened this issue Jul 11, 2024 · 2 comments · Fixed by #10594
Closed

[exporterhelper] Reconsider the need of Go API related to ObsReport #10592

dmitryax opened this issue Jul 11, 2024 · 2 comments · Fixed by #10594
Milestone
go.opentelemetry....

Comments

@dmitryax
Copy link
Member

receiverhelper.ObsReport is extensively used by many receivers in the contrib. However, exported API related to exporterhelper.ObsReport is not being used because that functionality is already incapsulated into top-level helpers exporterhelper.New[Metrics|Traces|Logs]Exporter and there is no reason to interact with exporterhelper.ObsReport directly.

Given that we want to limit exposed API before 1.0, I suggest we deprecate and remove public API in https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/exporterhelper/obsexporter.go
@dmitryax dmitryax mentioned this issue Jul 11, 2024
Merged
@dmitryax dmitryax changed the title [exporterhelper] Reconsider need of Go API related to ObsReport [exporterhelper] Reconsider the need of Go API related to ObsReport Jul 11, 2024
@dmitryax
Copy link
Member Author

@codeboten please let me know if it makes sense to you

@codeboten
Copy link
Contributor

Yup, makes sense

@github-project-automation github-project-automation bot moved this from Todo to Done in Collector: v1 Jul 11, 2024
@atoulme atoulme mentioned this issue Aug 1, 2024
Merged
codeboten pushed a commit that referenced this issue Aug 7, 2024
@atoulme
[exporterhelper] delete deprecated exporterhelper.ObsReport (#10779)
c469394 
#### Description
Delete deprecated `exporterhelper.ObsReport` and
`exporterhelper.NewObsReport`

#### Link to tracking issue
Relates to
#10592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Collector: v1
Archived in project
Milestone
go.opentelemetry.io/exporter 1.0
Development

Successfully merging a pull request may close this issue.

[exporterhelper] Deprecate the obsreport API dmitryax/opentelemetry-collector
2 participants
@codeboten @dmitryax