-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access application version in components #1559
Comments
While version is the immediate use case that needs this feature, it may make more sense to support a generic way of passing the pipeline-level metadata. e.g. if in the exporter we want to distinguish the "distro" it's being used in ( type ApplicationInfo interface {
Name() string // e.g. "opentelemetry-collector"
Version() string // e.g. "v0.10.0"
} and pass it to all component constructors. |
Good point - maybe we could just pass in the ApplicationStartInfo struct directly: https://github.com/open-telemetry/opentelemetry-collector/blob/v0.8.0/service/service.go#L101 |
Closing this as done because PR #1582 was merged |
* Vendor Thrift dependency * Fix build * Changelog entry * Ignore third_party for coverage purposes * Re-run tests * Re-run tests * Re-run tests * Re-run tests * Relax time comparisons Fixes open-telemetry#1559. Some unit tests were flaking in CI because they expected the timestamp to advance during a test, when it's possible for it to be unchanged instead. This change switches the offending "<" comparisons to "<=". * Re-run tests * Relax more time comparisons * Re-run tests Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
* Stagger timestamps in exact aggregator tests Fixes open-telemetry#1559. * Missed one * Yield while you wait * Just sleep for a teeny tiny bit * Oops, wrong PR in Changelog * Make sure that *some* time passes * Keep time comparisons relaxed
Is your feature request related to a problem? Please describe.
I would like to include the application version in metadata on requests sent by an exporter.
Describe the solution you'd like
Add the version string to the parameters passed to components on initialization, i.e. update https://github.com/open-telemetry/opentelemetry-collector/blob/v0.8.0/component/exporter.go#L97 (similar for other components)
When building the pipelines, set this value based on the value provided in https://github.com/open-telemetry/opentelemetry-collector/blob/v0.8.0/service/service.go#L109
The text was updated successfully, but these errors were encountered: