-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review TLS support for OC receiver and add tests #170
Comments
@pjanotti I would like to take this one since I'm working on improving oc receiver documentation and test coverage! |
The code used here should be shared with fix for #126 - in principle it should be possible to share gRPC configuration settings/code between different gRPC receivers and exporters. |
@pjanotti +1 This chunk of code for generating grpc calloptions from the common opentelemetry-collector/exporter/opencensusexporter/factory.go Lines 73 to 81 in 63362d5
|
I think we now have ConfigGrpc that has all of these things. |
Hello, can I ask if anyone has tested or gotten an OpenCensus instrumented application using the My poc works when the However when TLS credentials are set on both sides, the The same TLS files are valid because they worked with an OT instrumented app and the collector configured with the OT receiver using mTLS. I feel like I'm missing a piece here and hope to find someone who's been able to confirm or deny if there's a problem with |
TLS config for OC receiver is being added via #167 however in light of census-instrumentation/opencensus-service#596 I think we need to revisit the implementation and tests here.
The text was updated successfully, but these errors were encountered: