Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review TLS support for OC receiver and add tests #170

Closed
pjanotti opened this issue Jul 18, 2019 · 5 comments
Closed

Review TLS support for OC receiver and add tests #170

pjanotti opened this issue Jul 18, 2019 · 5 comments
Assignees

Comments

@pjanotti
Copy link
Contributor

TLS config for OC receiver is being added via #167 however in light of census-instrumentation/opencensus-service#596 I think we need to revisit the implementation and tests here.

@ccaraman
Copy link
Contributor

@pjanotti I would like to take this one since I'm working on improving oc receiver documentation and test coverage!

@pjanotti pjanotti assigned pjanotti and ccaraman and unassigned pjanotti Jul 30, 2019
@pjanotti
Copy link
Contributor Author

pjanotti commented Aug 2, 2019

The code used here should be shared with fix for #126 - in principle it should be possible to share gRPC configuration settings/code between different gRPC receivers and exporters.

@annanay25
Copy link
Contributor

annanay25 commented Sep 22, 2019

@pjanotti +1

This chunk of code for generating grpc calloptions from the common grpcsettings can also be moved to common, so all exporters/receivers can share? -

if ocac.Endpoint == "" {
return nil, &ocExporterError{
code: errEndpointRequired,
msg: "OpenCensus exporter config requires an Endpoint",
}
}
opts := []ocagent.ExporterOption{ocagent.WithAddress(ocac.Endpoint)}
if ocac.Compression != "" {
if compressionKey := compressiongrpc.GetGRPCCompressionKey(ocac.Compression); compressionKey != compression.Unsupported {

@bogdandrutu
Copy link
Member

I think we now have ConfigGrpc that has all of these things.

@tonglil
Copy link
Contributor

tonglil commented Mar 18, 2021

Hello, can I ask if anyone has tested or gotten an OpenCensus instrumented application using the ocagent exporter to send to a OpenTelemetry collector configured with the OpenCensus receiver, using mTLS (mutual TLS)?

My poc works when the ocagent is set to insecure, as the collector logs the traces.

However when TLS credentials are set on both sides, the ocagent seems to hang on connecting and the collector shows 0 traces.

The same TLS files are valid because they worked with an OT instrumented app and the collector configured with the OT receiver using mTLS.

I feel like I'm missing a piece here and hope to find someone who's been able to confirm or deny if there's a problem with ocagent or the collector? Happy to share my code to reproduce.

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants