Track @mx-psi interest and contributions for approver

[bogdandrutu]

Hi @mx-psi,

This is a tracking issue to know if you are interested and have time to become approver for the collector repository. If yes please confirm here, and we should track contributions here to ensure when requirements are met we add you to the approver list.

[mx-psi]

Hi,

Yes, I am interested and have time! So far, in terms of PRs to the opentelemetry-collector repo I did #2296 and #2378 some time ago (those were minor docs & examples PRs) and recently I have done #2728. I will start referencing this issue on the PRs I open on this repo.

[mx-psi]

Pull requests opened (core)

• [examples] Remove queued_retry processor from Kubernetes example [examples] Remove queued_retry processor from Kubernetes example #2296
• [consumer] Fix comments referencing MetricsData [consumer] Fix comments referencing MetricsData #2378
• Create configload.Parser struct to abstract away from Viper Create configload.Parser struct to abstract away from Viper #2728
• [translator/conventions] Add task revision semantic convention [translator/conventions] Add task revision semantic convention #2816
• Add missing documentation Add missing documentation #2837
• Move Unmarshaler interface to Config instead of Factory Move Unmarshaler interface to Config instead of Factory #2867
• Move some unmarshaling errors to the Validate method Move some unmarshaling errors to the Validate method #2929
• Error checking on unit tests Error checking on unit tests #2959
• (In progress) Fix some errcheck errors Fix some errcheck errors #2881

Pull requests opened (contrib)

• Datadog exporter (18 PRs if I am counting correctly)
• System resource detector ([resourcedetectionprocessor] Initial system detector opentelemetry-collector-contrib#1405, [system detector] Fallback to os.Hostname when FQDN is not available opentelemetry-collector-contrib#3099, [system detector] Correctly report DRAGONFLYBSD value opentelemetry-collector-contrib#3100)
• Azure resource detector ([resourcedetectionprocessor] Azure detector opentelemetry-collector-contrib#2372)
• Misc improvements on AWS resource detectors ([resourcedetectionprocessor] Add EC2 hostname attribute opentelemetry-collector-contrib#1324, [resourcedetectionprocessor] Add task revision to ECS resource detector opentelemetry-collector-contrib#2814, [ECS detector] Use conventions package constants opentelemetry-collector-contrib#3171)

Reviews (core)

18 PRs reviewed so far (list here), mostly related to configuration unmarshaling and validation

Reviews (contrib)

44 PRs reviewed so far (list here), mostly on the components I (co-)own (Datadog exporter, system detector, Azure detector)

[bogdandrutu]

@mx-psi any update on this?

[mx-psi]

Hey @bogdandrutu, still interested on becoming an approver! :)

In terms of my contributions to this repository so far, an update from the last message would be:

• I have done a total of 26 pull requests including
  • testing and linting improvements ([golangci-lint] Remove unused exclude rules #4463, Enable errcheck linter #4462, Error checking on unit tests #2959, Switch to revive from golint #3182, also some work on Enable all disabled checks options in golangci-lint, see #2786 #2789 (comment) that didn't make it into a PR)
  • changes to the configuration (Create configload.Parser struct to abstract away from Viper #2728, Move Unmarshaler interface to Config instead of Factory #2867, Move some unmarshaling errors to the Validate method #2929, Move MapProvider to config package #4178, Move service/parserprovider package to config/configmapprovider #4206, Move MapProvider interfaces to config/configmapprovider package #4337),
  • future-proofing the public API of interfaces (Make component.Factory inherit internalinterface.InternalInterface #4338, [component] Embed nil ProcessorFactory #4336, Remove BaseProcessorFactory, force using helper #4175),
  • changes to support embedding the Collector on an existing application ([service] Fix panic when not using NewCommand #4139, Improve logging on telemetry initialization #4189, I have a couple more issues/PRs to open here)
• I have reviewed 90 PRs including both code reviews, design reviews and process PRs.
• I have created 14 issues, including code bugs, design aspects (e.g. Allow running service.Collector without CLI interface #3957) or process aspects ([Proposal] Go language version support #4841) and I have tried to coach contributors when they were easy (e.g. on exporterhelper should reject a queue size of 0 #4584 and Return an error on config.Map.Set #4467)
• I have participated on issues discussions on design aspects (e.g. Better place for the release artifacts #4835, [Decision to be made] Approach to handle experimental types of telemetry #4705, Allow Factories to support new signals #3921, Split pdata into multiple packages #4832)

I would be happy to become an approver and I would have time to review PRs and/or handle releases that come my way. If I need to do more work, it would be nice to have specific feedback on what you would want to see.