Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add factory and new-style config for Prometheus exporter #38

Closed
tigrannajaryan opened this issue Jun 21, 2019 · 1 comment
Closed

Add factory and new-style config for Prometheus exporter #38

tigrannajaryan opened this issue Jun 21, 2019 · 1 comment
Assignees
@tigrannajaryan

Comments

@tigrannajaryan
Copy link
Member

See OpenCensus exporter factory.go and config.go as an example.
pjanotti referenced this issue in pjanotti/opentelemetry-service Jun 27, 2019
@rakyll
Rename opencensusd to ocagent (#38)
61d8c04
@tigrannajaryan tigrannajaryan added help wanted Good issue for contributors to OpenTelemetry Service to pick up and removed help wanted Good issue for contributors to OpenTelemetry Service to pick up labels Jul 2, 2019
@tigrannajaryan tigrannajaryan self-assigned this Jul 2, 2019
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jul 2, 2019
Implement Prometheus factory and config V2
37e3ff7 
Github issue: open-telemetry#38

Testing done:

- make
- Run with the following config and make sure Prometheus can scrape :

receivers:
  opencensus:
    port: 55678

  prometheus:
    config:
      scrape_configs:
        - job_name: 'demo'
          scrape_interval: 5s

zpages:
  port: 55679

exporters:
  prometheus:
    endpoint: "127.0.0.1:8889"

pipelines:
  metrics:
    receivers: [prometheus]
    exporters: [prometheus]
@tigrannajaryan tigrannajaryan mentioned this issue Jul 2, 2019
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jul 2, 2019
Implement Prometheus factory and config V2
c7af8dd 
Github issue: open-telemetry#38

Testing done:

- make && make otelsvc
- Run otelsvc with the following config and make sure Prometheus can scrape :

receivers:
  opencensus:
    port: 55678

  prometheus:
    config:
      scrape_configs:
        - job_name: 'demo'
          scrape_interval: 5s

zpages:
  port: 55679

exporters:
  prometheus:
    endpoint: "127.0.0.1:8889"

pipelines:
  metrics:
    receivers: [prometheus]
    exporters: [prometheus]
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jul 2, 2019
Implement Prometheus factory and config V2
f8f5144 
Github issue: open-telemetry#38

Testing done:

- make && make otelsvc
- Run otelsvc with the following config and make sure Prometheus can scrape :

receivers:
  opencensus:
    port: 55678

  prometheus:
    config:
      scrape_configs:
        - job_name: 'demo'
          scrape_interval: 5s

zpages:
  port: 55679

exporters:
  prometheus:
    endpoint: "127.0.0.1:8889"

pipelines:
  metrics:
    receivers: [prometheus]
    exporters: [prometheus]
tigrannajaryan added a commit that referenced this issue Jul 3, 2019
@tigrannajaryan
Implement Prometheus factory and config V2 (#89)
886e62f 
Github issue: #38

Testing done:

- make && make otelsvc
- Run otelsvc with the following config and make sure Prometheus can scrape :

receivers:
  opencensus:
    port: 55678

  prometheus:
    config:
      scrape_configs:
        - job_name: 'demo'
          scrape_interval: 5s

zpages:
  port: 55679

exporters:
  prometheus:
    endpoint: "127.0.0.1:8889"

pipelines:
  metrics:
    receivers: [prometheus]
    exporters: [prometheus]
@tigrannajaryan
Copy link
Member Author

Done.

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@thinkerou @rghetia
check interface implement for metric (open-telemetry#38)
56fe193
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@flands
Update README (open-telemetry#38)
357311f
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@eyakimov-bbg
WIP: Added docs/library-distribution.md (open-telemetry#38)
f2c1e99 
Added docs/library-distribution.md
Started to clarify how the library can be distributed
Co-authored-by: Ryan Burn <ryan.burn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tigrannajaryan